Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IS THIS REPO DEAD??? #671

Open
theofred opened this issue Oct 16, 2024 · 8 comments
Open

IS THIS REPO DEAD??? #671

theofred opened this issue Oct 16, 2024 · 8 comments

Comments

@theofred
Copy link

theofred commented Oct 16, 2024

At the time of writing, this repository has 190 open issues and 18 open pull requests.
The last reasonable changes to the code were 12 months ago. Some of the pull requests are tested by the community and offer valid improvements.

Right now (version 1.5.1) this package is not working with the official recommended Azure Function version (.net 8 and isolated worker model) out of the box and there is no obvious workaround.
e.g. see #663 #596

Is this repo dead, or who can be addressed for maintenance reasons, improvements or pull requests? Or has Microsoft other plans for this package?

Would like to hear from maintainers so people could decide whether this package will be pick worth or not.

@vrdmr @justinyoo ?

edit: sorry for the dramatic title, but click bait works better

@theofred theofred changed the title Who is maintaining this repo? IS THIS REPO DEAD??? Oct 18, 2024
@Skovvart
Copy link

It is for all intents and purposes dead with no active maintainer re #645
Based of LinkedIn @justinyoo is focusing on azd/aspire/AI stuff and the torch has not been passed off to anyone else.

@fabiocav you unpinned #357, can you chime in on the situation? It is frustrating as a consumer to have this radio silence.

@fabiocav
Copy link
Member

Thank you for your patience and for reaching out.

It is likely that our team will be taking over ownership of this repository. We're currently working internally to confirm the transition details and once that is finalized, we'll be onboarding this onto our processes and working on triage and reviews.

I appreciate your understanding and will provide updates on the repo as soon as we have more information.

Thanks again!

@JeroenvdBurg
Copy link

Thank you for your patience and for reaching out.

It is likely that our team will be taking over ownership of this repository. We're currently working internally to confirm the transition details and once that is finalized, we'll be onboarding this onto our processes and working on triage and reviews.

I appreciate your understanding and will provide updates on the repo as soon as we have more information.

Thanks again!

@fabiocav Thanks for the reply. If the team takes ownership of this repo it would be great to update to the new 2.0 Function Worker. This includes the adjusted Function builder which is compatible with .net Aspire.

Keep up the good work. 👍

@nlykkei
Copy link

nlykkei commented Jan 7, 2025

@JeroenvdBurg You mention 2.0 Function Worker. I currently experience very slow performance for all of the Swagger endpoints exposed by this library, irrespective of the hosted plan. Could the 1.0 Function Worker be the reason?

@JeroenvdBurg
Copy link

@JeroenvdBurg You mention 2.0 Function Worker. I currently experience very slow performance for all of the Swagger endpoints exposed by this library, irrespective of the hosted plan. Could the 1.0 Function Worker be the reason?

Not totally sure, but we have used the 1.18 version together with the openApi extension and that was working without any performance issues. We are evaluating 2.0 now together with .NET aspire (preview).

@nlykkei
Copy link

nlykkei commented Jan 8, 2025

@JeroenvdBurg I'm using Function Host version ~4 with OpenAPI extension:

<PackageReference Include="Microsoft.Azure.Functions.Worker.Extensions.OpenApi" Version="1.5.1" />

I just tested it again, and the load time for the Swagger UI is about 20-25 seconds, which is too slow:

https://func-assetgov-staging-weu.azurewebsites.net/api/swagger/ui

The Swaggger UI is minimal, but it renders with an "invalid" Swagger validator badge:

https://validator.swagger.io/validator/debug?url=https%3A%2F%2Ffunc-assetgov-staging-weu.azurewebsites.net%2Fapi%2Fswagger.json

Image

Do you have any suggestions? I would appreciate your feedback :)

@JeroenvdBurg
Copy link

I think this is just the cold start of your azure website/function app. If you host it in azure website make sure you turn on Always on at the settings.

@nlykkei
Copy link

nlykkei commented Jan 8, 2025

@JeroenvdBurg Thank you, but isn't a cold start supposed to take 2-3 seconds? :)

Have you found a solution to the "Invalid" Swagger Validator badge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants