Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry tracing plugin #4120

Closed
2 tasks
lmolkova opened this issue Nov 15, 2022 · 1 comment
Closed
2 tasks

OpenTelemetry tracing plugin #4120

lmolkova opened this issue Nov 15, 2022 · 1 comment
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific)

Comments

@lmolkova
Copy link
Member

lmolkova commented Nov 15, 2022

This is an uber-issue to track C++ tracing work necessary to GA otel plugin.

[Ge] Tasks

Preview Give feedback
  1. Client OpenTelemetry
  2. Client OpenTelemetry

Sub-tasks:

  • Support telemetry schema versioning (attribute names). User should be able to set OTel schema version from an enum we provide and OTel plugin should map attribute names according to given version. OTel schema version

    • Set it on tracer's instrumentation scope
    • Support 1.17.0 initially only (TBD - will switch to latest by GA)
    • Map attribute names reported by SDKs to corresponding ones in configured schema version. Here's the current list https://github.com/azure/azure-sdk/blob/main/docs/tracing/distributed-tracing-conventions.yml
    • We'll add new versions every once in a while and users will be able to configure them.
    • Don't change attribute names in SDKs
    • [nice-to-have] Set client library name and version on tracer instrumentation scope
  • Cleanups and breaking changes

    • Nested logical spans suppression by default (new guidelines) "When client method creates a new span and internally calls into other public client methods of the same or different Azure SDK, spans created for inner client methods MUST be suppressed, their attributes and events ignored. Nested spans created for REST calls MUST be the children of the outer client call span. Suppression is generally done by Azure Core."
  • Testing

    • Perf testing: e.g. run storage perf tests with tracing enabled.
    • [nice-to-have] Sample app
  • Misc

    • Update docs
    • [nice-to-have] Add tracing to common TSG
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 15, 2022
@lmolkova lmolkova added this to the 2023-04 milestone Nov 15, 2022
@lmolkova lmolkova added Client This issue points to a problem in the data-plane of the library. OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific) and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Nov 15, 2022
@RickWinter RickWinter removed this from the 2023-04 milestone Jun 8, 2023
@RickWinter RickWinter changed the title [Zn] OpenTelemetry tracing plugin uber-task OpenTelemetry tracing plugin Mar 12, 2024
Copy link

Hi @lmolkova, we deeply appreciate your input into this project. Regrettably, this issue has remained unresolved for over 2 years and inactive for 30 days, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 15, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific)
Projects
None yet
Development

No branches or pull requests

3 participants