From f360cb1b4fbf0b04f428b6b01fcf7a3e84cb46c8 Mon Sep 17 00:00:00 2001 From: Jeremy Meng Date: Fri, 17 Jan 2025 13:37:24 -0800 Subject: [PATCH] [storage][test] fix integration by double-quoting file patterns (#32584) The recent Mocha upgrades broke storage integration tests on Windows, likely due to their upgrade of yargs dependency. With single quotes, we now get errors like >Error: No test files found: "'dist-esm/storage-file-share/test/**/*.spec.js'" This PR changes to use escaped doubled quotes in the scripts. --- sdk/storage/storage-blob-changefeed/package.json | 2 +- sdk/storage/storage-blob/package.json | 2 +- sdk/storage/storage-file-datalake/package.json | 2 +- sdk/storage/storage-file-share/package.json | 2 +- sdk/storage/storage-queue/package.json | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/sdk/storage/storage-blob-changefeed/package.json b/sdk/storage/storage-blob-changefeed/package.json index ed6269296f10..e389f95726a2 100644 --- a/sdk/storage/storage-blob-changefeed/package.json +++ b/sdk/storage/storage-blob-changefeed/package.json @@ -31,7 +31,7 @@ "format": "dev-tool run vendored prettier --write --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.ts\" \"test/**/*.ts\" \"samples-dev/**/*.ts\" \"*.{js,json}\"", "integration-test": "npm run integration-test:node && npm run integration-test:browser", "integration-test:browser": "dev-tool run test:browser", - "integration-test:node": "dev-tool run test:node-js-input -- --timeout 5000000 'dist-esm/storage-blob-changefeed/test/**/*.spec.js'", + "integration-test:node": "dev-tool run test:node-js-input -- --timeout 5000000 \"dist-esm/storage-blob-changefeed/test/**/*.spec.js\"", "lint": "eslint package.json api-extractor.json src test", "lint:fix": "eslint package.json api-extractor.json src test --fix", "pack": "npm pack 2>&1", diff --git a/sdk/storage/storage-blob/package.json b/sdk/storage/storage-blob/package.json index 91b8755415b9..aae5c788b8e1 100644 --- a/sdk/storage/storage-blob/package.json +++ b/sdk/storage/storage-blob/package.json @@ -45,7 +45,7 @@ "generate:client": "autorest --typescript ./swagger/README.md", "integration-test": "npm run integration-test:node && npm run integration-test:browser", "integration-test:browser": "dev-tool run test:browser", - "integration-test:node": "dev-tool run test:node-js-input -- --timeout 5000000 'dist-esm/storage-blob/test/*.spec.js' 'dist-esm/storage-blob/test/node/*.spec.js'", + "integration-test:node": "dev-tool run test:node-js-input -- --timeout 5000000 \"dist-esm/storage-blob/test/*.spec.js\" \"dist-esm/storage-blob/test/node/*.spec.js\"", "lint": "eslint package.json api-extractor.json README.md src test", "lint:fix": "eslint package.json api-extractor.json README.md src test --fix", "pack": "npm pack 2>&1", diff --git a/sdk/storage/storage-file-datalake/package.json b/sdk/storage/storage-file-datalake/package.json index 1b22d920b564..0bed270c3bbd 100644 --- a/sdk/storage/storage-file-datalake/package.json +++ b/sdk/storage/storage-file-datalake/package.json @@ -41,7 +41,7 @@ "generate:client": "autorest --typescript ./swagger/README.md", "integration-test": "npm run integration-test:node && npm run integration-test:browser", "integration-test:browser": "dev-tool run test:browser", - "integration-test:node": "dev-tool run test:node-js-input -- --timeout 5000000 'dist-esm/storage-file-datalake/test/*.spec.js' 'dist-esm/storage-file-datalake/test/node/*.spec.js'", + "integration-test:node": "dev-tool run test:node-js-input -- --timeout 5000000 \"dist-esm/storage-file-datalake/test/*.spec.js\" \"dist-esm/storage-file-datalake/test/node/*.spec.js\"", "lint": "eslint package.json api-extractor.json README.md src test", "lint:fix": "eslint package.json api-extractor.json README.md src test --fix", "pack": "npm pack 2>&1", diff --git a/sdk/storage/storage-file-share/package.json b/sdk/storage/storage-file-share/package.json index 2d75d1c7a79c..b5c74950af00 100644 --- a/sdk/storage/storage-file-share/package.json +++ b/sdk/storage/storage-file-share/package.json @@ -41,7 +41,7 @@ "generate:client": "autorest --typescript ./swagger/README.md", "integration-test": "npm run integration-test:node && npm run integration-test:browser", "integration-test:browser": "dev-tool run test:browser", - "integration-test:node": "dev-tool run test:node-js-input -- --timeout 5000000 'dist-esm/storage-file-share/test/**/*.spec.js'", + "integration-test:node": "dev-tool run test:node-js-input -- --timeout 5000000 \"dist-esm/storage-file-share/test/**/*.spec.js\"", "lint": "eslint package.json api-extractor.json README.md src test", "lint:fix": "eslint package.json api-extractor.json README.md src test --fix", "pack": "npm pack 2>&1", diff --git a/sdk/storage/storage-queue/package.json b/sdk/storage/storage-queue/package.json index b362c04238db..b3bb9624259b 100644 --- a/sdk/storage/storage-queue/package.json +++ b/sdk/storage/storage-queue/package.json @@ -37,7 +37,7 @@ "generate:client": "autorest --typescript ./swagger/README.md", "integration-test": "npm run integration-test:node && npm run integration-test:browser", "integration-test:browser": "dev-tool run test:browser", - "integration-test:node": "dev-tool run test:node-js-input -- --timeout 5000000 'dist-esm/storage-queue/test/**/*.spec.js'", + "integration-test:node": "dev-tool run test:node-js-input -- --timeout 5000000 \"dist-esm/storage-queue/test/**/*.spec.js\"", "lint": "eslint package.json api-extractor.json README.md src test", "lint:fix": "eslint package.json api-extractor.json README.md src test --fix", "pack": "npm pack 2>&1",