Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AzureContainerRegistry tests failing #31934

Closed
jeremymeng opened this issue Nov 25, 2024 · 2 comments · Fixed by #31961
Closed

AzureContainerRegistry tests failing #31934

jeremymeng opened this issue Nov 25, 2024 · 2 comments · Fixed by #31961
Labels
Client This issue points to a problem in the data-plane of the library. Container Registry

Comments

@jeremymeng
Copy link
Member

may be related to CAE change? Nightly started failing on the same day CAE changes went in.

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4308167&view=results

Live tests also failing: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4358042&view=logs&j=43701d7e-216c-59bf-08d1-1efd0c7ac90a&t=837467d0-f383-5ba6-1b1a-21aa68346dfb&l=138

@jeremymeng jeremymeng added Client This issue points to a problem in the data-plane of the library. Container Registry labels Nov 25, 2024
@jeremymeng
Copy link
Member Author

/cc @minhanh-phan @timovv

@timovv
Copy link
Member

timovv commented Nov 25, 2024

Almost certainly related to CAE. We may need to do what Key Vault did and roll out a custom policy for ACR. It's concerning that this actually caused things to break though -- I was under the impression that we would need extra work in ACR to enable CAE support, but the existing policy should still function. Maybe there's a bug in Core where we aren't dealing with custom challenge handlers properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Container Registry
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants