Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare JS SDK for compute TypeSpec migration #32007

Open
Tracked by #1850
live1206 opened this issue Dec 2, 2024 · 4 comments
Open
Tracked by #1850

Compare JS SDK for compute TypeSpec migration #32007

live1206 opened this issue Dec 2, 2024 · 4 comments
Assignees
Labels
Compute Mgmt This issue is related to a management-plane library. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team

Comments

@live1206
Copy link
Member

live1206 commented Dec 2, 2024

We are working on the compute TypeSpec migration.
Would like JS to verify the SDK generation of the corresponding swagger of the converted TypeSpec.
We have split compute into multiple sub services and done the conversion for each of them.

For instance, Compute sub-service:

@github-actions github-actions bot added Compute Mgmt This issue is related to a management-plane library. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Service Attention Workflow: This issue is responsible by Azure service team. labels Dec 2, 2024
Copy link

github-actions bot commented Dec 2, 2024

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @amjads1 @avirishuv @Drewm3 @Vaibhav-Agar.

@live1206 live1206 removed the Service Attention Workflow: This issue is responsible by Azure service team. label Dec 2, 2024
@qiaozha
Copy link
Member

qiaozha commented Dec 2, 2024

we will have internal investigation first.

@qiaozha
Copy link
Member

qiaozha commented Dec 18, 2024

@kazrael2119 could you help do the following steps and provide the commit id between step 2 and step 4? we want to verify the converted typespec works, thanks

  1. remove those swaggers that don't have corresponding spec.
  2. regen the modified swaggers with our latest codegen in sdk repo, then commit it
  3. generate the generated swagger from the typespec compile in the spec repo.
  4. regen the generated swagger with our latest codegen in sdk repo, then commit it.

@kazrael2119
Copy link
Contributor

kazrael2119 commented Jan 8, 2025

diff: #33054

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compute Mgmt This issue is related to a management-plane library. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team
Projects
None yet
Development

No branches or pull requests

3 participants