Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[azure-core-tracing-opentelemetry] Adopt OpenTelemetry error.type attribute for logical calls #32804

Closed
Tracked by #32806
lmolkova opened this issue Oct 27, 2023 · 0 comments · Fixed by #34619
Closed
Tracked by #32806

[azure-core-tracing-opentelemetry] Adopt OpenTelemetry error.type attribute for logical calls #32804

lmolkova opened this issue Oct 27, 2023 · 0 comments · Fixed by #34619
Assignees
@pvaneck
Labels
Client This issue points to a problem in the data-plane of the library. OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific)

Comments

@lmolkova
Copy link
Member

lmolkova commented Oct 27, 2023 •
edited
Loading

OTel defined error.type attribute we can use to report low-cardinality failures with.

We should add it where SDKs end spans with error.
(as long as it does not conflict with HTTP-level error.type we're going to set in #32803)
@lmolkova lmolkova added Client This issue points to a problem in the data-plane of the library. OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific) labels Oct 27, 2023
@lmolkova lmolkova mentioned this issue Oct 27, 2023
Closed
6 tasks
@pvaneck pvaneck self-assigned this Jan 24, 2024
@pvaneck pvaneck mentioned this issue Mar 5, 2024
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pvaneck pvaneck

Labels
Client This issue points to a problem in the data-plane of the library. OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Tracing] Add error.type attribute to spans pvaneck/azure-sdk-for-python
2 participants
@pvaneck @lmolkova