Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eventhubs: minor errata with the Producer #2129

Open
3 tasks
richardpark-msft opened this issue Feb 12, 2025 · 0 comments
Open
3 tasks

eventhubs: minor errata with the Producer #2129

richardpark-msft opened this issue Feb 12, 2025 · 0 comments
Labels
needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team.

Comments

@richardpark-msft
Copy link
Member

  • ProducerClient allows you to set the maximum message size at the client level. In Go, the only place a message size can be set is when creating a batch. I believe that's the case, across the board.
  • submit_batch should be renamed, as we generally use 'send' as the verb. So perhaps either send_batch(), or send_event_batch()?
  • batch.len() and batch.size() were confusing to me when looking through EventBatch's methods. What do you think about renaming size() to size_in_bytes(), or similar?
@github-project-automation github-project-automation bot moved this to Untriaged in Azure SDK Rust Feb 12, 2025
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team.
Projects
Status: Untriaged
Development

No branches or pull requests

1 participant