Set spec.owner on root resource of import #4611
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
davefellows,
matthchr,
babbageclunk and
super-harsh
as code owners
There was a problem hiding this comment.
PR Overview
This PR sets the spec.owner for root resources during Azure resource imports by determining the owner from the ARM ID of the parent resource. Key changes include:
- Introducing the createOwnerFor method in the resource importer to extract a parent ARM ID.
- Adding helper methods (AsArbitraryOwnerReference and AsKnownResourceReference) in the ResourceReference type.
- Updating resource importer and importable ARM resource logic to use the new owner reference extraction methods.
Reviewed Changes
| File | Description |
|---|---|
| v2/cmd/asoctl/pkg/importresources/resource_importer.go | Adds owner extraction logic and proper error wrapping when creating an importer using a parent resource’s ARM ID. |
| v2/pkg/genruntime/resource_reference.go | Introduces and/or updates helper functions to convert a ResourceReference to owner reference types. |
| v2/cmd/asoctl/pkg/importresources/importable_arm_resource.go | Refactors inline owner reference synthesis to use the new helper functions in ResourceReference. |
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Sets the
spec.ownerof each root resource specified when importing existing Azure resources, using the ARM ID of the parent resource.Closes #4564
Example: If you import a Storage Account:
The owner will be set to the resource group
How does this PR make you feel?