Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate AmqpClient accepting a list of str for the desired capabilities #212

Open
yunhaoling opened this issue Feb 24, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@yunhaoling
Copy link
Contributor

yunhaoling commented Feb 24, 2021

In the current world, AmqpClient only accepts AMQPValue for the desired capabilities:

:param desired_capabilities: The extension capabilities desired from the peer endpoint.
To create an desired_capabilities object, please do as follows:
- 1. Create an array of desired capability symbols: `capabilities_symbol_array = [types.AMQPSymbol(string)]`
- 2. Transform the array to AMQPValue object: `utils.data_factory(types.AMQPArray(capabilities_symbol_array))`
:type desired_capabilities: ~uamqp.c_uamqp.AMQPValue

However, this means the upper applications have to construct the AMQPString/AMQPSymbol/AMQPArray/AMQPValue by themselves.

It would be nice if we could considering adding the support to accept just a list of string, and we do the conversion internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant