Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVM Module Issue]: Enable serverless capability as a general setup #3753

Open
1 task done
dmusic opened this issue Nov 8, 2024 · 4 comments
Open
1 task done

[AVM Module Issue]: Enable serverless capability as a general setup #3753

dmusic opened this issue Nov 8, 2024 · 4 comments
Assignees
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request

Comments

@dmusic
Copy link

dmusic commented Nov 8, 2024

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Feature Request

Module Name

avm/res/document-db/database-account

(Optional) Module Version

0.8.1

Description

In current version of the CosmosDB AVM module, users of the module need to create a "dummy" database for NoSQL, Gremlin, MongoDB and Table APIs to be able to enable serverless capacity mode.

The affected code in module is this:

{
  databaseAccountOfferType: databaseAccountOfferType
  backupPolicy: backupPolicy
  minimalTlsVersion: minimumTlsVersion
},
((!empty(sqlDatabases) || !empty(mongodbDatabases) || !empty(gremlinDatabases) || !empty(tables))
  ? {
     ...
     **capabilities: capabilities**
     ...
 }

As this is general configuration, this should be moved in the first part of that union, including databaseAccountOfferType, backupPolicy and TLS config.
This would improve the product and remove demand to create "dummy" databases to set correct serverless capacity mode.

This should be a quick fix and would benefit the product.

(Optional) Correlation Id

#2189

@dmusic dmusic added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Nov 8, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@avm-team-linter avm-team-linter bot added the Class: Resource Module 📦 This is a resource module label Nov 8, 2024
Copy link

@dmusic, thanks for submitting this issue for the avm/res/document-db/database-account module!

Important

A member of the @Azure/avm-res-documentdb-databaseaccount-module-owners-bicep or @Azure/avm-res-documentdb-databaseaccount-module-contributors-bicep team will review it soon!

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days label Nov 13, 2024
@bryansan-msft bryansan-msft removed Needs: Triage 🔍 Maintainers need to triage still Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days labels Nov 14, 2024
@seesharprun
Copy link
Contributor

@bryansan-msft, there seems to be multiple issues where users would like to see features like publicNetworkAccess and capabilities outside of the conditional so they can use them even if they don't define sub-resources.

This would require a significant rework of the document-db module to make happen. Is this something you want to discuss in a new issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request
Projects
Status: Needs: Triage
Development

No branches or pull requests

3 participants