From 49e0152a202aeb3ab3a7b2fac31814bcc306ce6e Mon Sep 17 00:00:00 2001 From: mgamis-msft <79475487+mgamis-msft@users.noreply.github.com> Date: Thu, 24 Oct 2024 17:00:11 +0000 Subject: [PATCH 1/2] Fix BreakoutRoomsBanner component to return null instead of undefined when there is no breakout room state --- .../CallComposite/components/BreakoutRoomsBanner.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react-composites/src/composites/CallComposite/components/BreakoutRoomsBanner.tsx b/packages/react-composites/src/composites/CallComposite/components/BreakoutRoomsBanner.tsx index 5f1037f39bf..6f02eaec7bc 100644 --- a/packages/react-composites/src/composites/CallComposite/components/BreakoutRoomsBanner.tsx +++ b/packages/react-composites/src/composites/CallComposite/components/BreakoutRoomsBanner.tsx @@ -25,7 +25,7 @@ import { Banner } from './Banner'; export const BreakoutRoomsBanner = (props: { locale: CompositeLocale; adapter: CommonCallAdapter; -}): JSX.Element | undefined => { +}): JSX.Element | null => { const { locale, adapter } = props; const assignedBreakoutRoom = useSelector(getAssignedBreakoutRoom); @@ -61,5 +61,5 @@ export const BreakoutRoomsBanner = (props: { ); } - return undefined; + return null; }; From 1b053506ee50b23db67d67573c32beffb3ea515f Mon Sep 17 00:00:00 2001 From: mgamis-msft <79475487+mgamis-msft@users.noreply.github.com> Date: Thu, 24 Oct 2024 17:03:11 +0000 Subject: [PATCH 2/2] Change files --- ...ation-react-3770976d-8796-497c-b460-2f38b8b95e39.json | 9 +++++++++ ...ation-react-3770976d-8796-497c-b460-2f38b8b95e39.json | 9 +++++++++ 2 files changed, 18 insertions(+) create mode 100644 change-beta/@azure-communication-react-3770976d-8796-497c-b460-2f38b8b95e39.json create mode 100644 change/@azure-communication-react-3770976d-8796-497c-b460-2f38b8b95e39.json diff --git a/change-beta/@azure-communication-react-3770976d-8796-497c-b460-2f38b8b95e39.json b/change-beta/@azure-communication-react-3770976d-8796-497c-b460-2f38b8b95e39.json new file mode 100644 index 00000000000..e428c87466d --- /dev/null +++ b/change-beta/@azure-communication-react-3770976d-8796-497c-b460-2f38b8b95e39.json @@ -0,0 +1,9 @@ +{ + "type": "patch", + "area": "fix", + "workstream": "Breakout rooms", + "comment": "Fix BreakoutRoomsBanner component to return null instead of undefined when there is no breakout room state", + "packageName": "@azure/communication-react", + "email": "79475487+mgamis-msft@users.noreply.github.com", + "dependentChangeType": "patch" +} diff --git a/change/@azure-communication-react-3770976d-8796-497c-b460-2f38b8b95e39.json b/change/@azure-communication-react-3770976d-8796-497c-b460-2f38b8b95e39.json new file mode 100644 index 00000000000..e428c87466d --- /dev/null +++ b/change/@azure-communication-react-3770976d-8796-497c-b460-2f38b8b95e39.json @@ -0,0 +1,9 @@ +{ + "type": "patch", + "area": "fix", + "workstream": "Breakout rooms", + "comment": "Fix BreakoutRoomsBanner component to return null instead of undefined when there is no breakout room state", + "packageName": "@azure/communication-react", + "email": "79475487+mgamis-msft@users.noreply.github.com", + "dependentChangeType": "patch" +}