Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Sender Options are not applied at Sender Initialization #247

Open
karenychen opened this issue Aug 14, 2024 · 0 comments
Open

Some Sender Options are not applied at Sender Initialization #247

karenychen opened this issue Aug 14, 2024 · 0 comments

Comments

@karenychen
Copy link
Contributor

karenychen commented Aug 14, 2024

go-shuttle/v2/sender.go

Lines 55 to 60 in 9be33d2

if options == nil {
options = &SenderOptions{Marshaller: &DefaultJSONMarshaller{}}
}
if options.SendTimeout == 0 {
options.SendTimeout = defaultSendTimeout
}

If senderOption is not nil, then we never set default Marshaller. The sender will run into a nil pointer dereference and panic.

@karenychen karenychen changed the title Sender will have an empty Marshaller if any other option is defined Sender Options are not getting taken in Properly Aug 14, 2024
@karenychen karenychen changed the title Sender Options are not getting taken in Properly Some Sender Options are not applied at Sender Initialization Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant