Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Typo: "Install blobfuse driver on a kubernetes cluster" for 1.7 and 1.8 #21

Open
GuyPaddock opened this issue Apr 3, 2019 · 3 comments

Comments

@GuyPaddock
Copy link

What happened:
The documentation for the command to use on Kubernetes 1.7 and 1.8 has a typo.

What you expected to happen:
The command provided for 1.7 & 1.8 should work.

How to reproduce it:
Review the steps under "for version v1.8 & v1.7" in https://github.com/Azure/kubernetes-volume-drivers/blob/master/flexvolume/blobfuse/README.md#2-install-blobfuse-driver-on-every-agent-vm.

Anything else we need to know?:

  • This command:

    kubectl apply -f https://raw.githubusercontent.com/Azure/kubernetes-volume-drivers/master/flexvolume/blobfuse/deployment/blobfuse-> flexvol-installer-1.8.yaml
    

    should probably be:

    kubectl apply -f https://raw.githubusercontent.com/Azure/kubernetes-volume-drivers/master/flexvolume/blobfuse/deployment/blobfuse-flexvol-installer-1.8.yaml
    
  • The formatting for the "for version v1.8 & v1.7" section should also be fixed to be consistent with the formatting of the section for 1.9.

@andyzhangx
Copy link
Collaborator

thanks, I have corrected the typo

@GuyPaddock
Copy link
Author

@andyzhangx what about my second bullet point?

  • The formatting for the "for version v1.8 & v1.7" section should also be fixed to be consistent with the formatting of the section for 1.9.

Sorry; I know that's kind of a separate issue that I sneaked in. 😅

@andyzhangx
Copy link
Collaborator

I set the format "for version v1.8 & v1.7" section like that mainly because 1.7 & 1.8 are deprecated in AKS version now:

az aks get-versions --location eastus2 -o table
KubernetesVersion    Upgrades
-------------------  ------------------------
1.12.7               None available
1.12.6               1.12.7
1.11.9               1.12.6, 1.12.7
1.11.8               1.11.9, 1.12.6, 1.12.7
1.10.13              1.11.8, 1.11.9
1.10.12              1.10.13, 1.11.8, 1.11.9
1.9.11               1.10.12, 1.10.13
1.9.10               1.9.11, 1.10.12, 1.10.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants