diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 5c57d80a..48270a3e 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -21,7 +21,7 @@ jobs: - name: Install rust stable uses: dtolnay/rust-toolchain@stable with: - toolchain: 1.79.0 + toolchain: 1.84.0 components: rustfmt, clippy - name: Run cargo check @@ -97,7 +97,7 @@ jobs: - name: Install rust stable uses: dtolnay/rust-toolchain@stable with: - toolchain: 1.79.0 + toolchain: 1.84.0 components: rustfmt, clippy - name: Run cargo check diff --git a/crates/libs/core/src/lib.rs b/crates/libs/core/src/lib.rs index 0a592398..71717c44 100644 --- a/crates/libs/core/src/lib.rs +++ b/crates/libs/core/src/lib.rs @@ -7,8 +7,8 @@ //! For most scenarios, you'll want the features. However, in some scenarios, such as: //! - integrating Rust into an existing Service Fabric Application written in another language //! - when you are using the lower-level COM API to do something more custom -//! You might not need all of the functionality that the mssf-core crate provides -//! In this case, you can configure only what you need to reduce dependencies and compile times. +//! You might not need all of the functionality that the mssf-core crate provides +//! In this case, you can configure only what you need to reduce dependencies and compile times. //! //! * ** config_source ** - //! Provides an implementation of config::Source. Requires config_rs crate diff --git a/crates/libs/core/src/runtime/stateful_proxy.rs b/crates/libs/core/src/runtime/stateful_proxy.rs index 8d28f410..9c8590a6 100644 --- a/crates/libs/core/src/runtime/stateful_proxy.rs +++ b/crates/libs/core/src/runtime/stateful_proxy.rs @@ -373,12 +373,12 @@ impl StatefulServicePartition { unsafe { self.com_impl.ReportMoveCost(move_cost.into()) } } - /// Remarks: - /// The health information describes the report details, like the source ID, the property, - /// the health state and other relevant details. The partition uses an internal health client - /// to send the reports to the health store. The client optimizes messages to Health Manager - /// by batching reports per a configured duration (Default: 30 seconds). If the report has high priority, - /// you can specify send options to send it immediately. + // Remarks: + // The health information describes the report details, like the source ID, the property, + // the health state and other relevant details. The partition uses an internal health client + // to send the reports to the health store. The client optimizes messages to Health Manager + // by batching reports per a configured duration (Default: 30 seconds). If the report has high priority, + // you can specify send options to send it immediately. /// Reports current partition health. pub fn report_partition_health(&self, healthinfo: &HealthInformation) -> crate::Result<()> { diff --git a/crates/libs/core/src/sync/bridge_context.rs b/crates/libs/core/src/sync/bridge_context.rs index a4252516..d5807923 100644 --- a/crates/libs/core/src/sync/bridge_context.rs +++ b/crates/libs/core/src/sync/bridge_context.rs @@ -103,7 +103,8 @@ where /// This api is in some sense unsafe, because the developer needs to ensure /// the following: /// * context impl type is `BridgeContext3`, and the T matches the SF end api - /// return type. + /// return type. + /// /// Note that if T is of Result type, the current function return type is /// Result>, so unwrap is needed. pub fn result(context: windows_core::Ref) -> crate::Result { diff --git a/crates/libs/core/src/types/common/metrics.rs b/crates/libs/core/src/types/common/metrics.rs index 1f7b1e62..ca583f63 100644 --- a/crates/libs/core/src/types/common/metrics.rs +++ b/crates/libs/core/src/types/common/metrics.rs @@ -42,7 +42,7 @@ pub struct LoadMetricListRef<'a> { owner: PhantomData<&'a [LoadMetric]>, } -impl<'a> LoadMetricListRef<'a> { +impl LoadMetricListRef<'_> { pub fn from_slice(v: &[LoadMetric]) -> Self { let metrics = v.iter().map(FABRIC_LOAD_METRIC::from).collect::>(); Self { diff --git a/rust-toolchain.toml b/rust-toolchain.toml index 6cdef225..105b10f7 100644 --- a/rust-toolchain.toml +++ b/rust-toolchain.toml @@ -2,5 +2,5 @@ # cargo + rustup will use this to consistently build the project # with the same version across all checkouts and environments [toolchain] -channel = "1.79.0" +channel = "1.84.0" profile = "default"