Support ServicePartitionResolver with cache #57
Labels
enhancement
New feature or request
Comments
youyuanwu
added a commit
that referenced
this issue
Aug 13, 2024
Partial impl for #57 FabricClient can register the service notification filter and unregister it. See dotnet [documentation](https://learn.microsoft.com/en-us/dotnet/api/system.fabric.fabricclient.servicemanagementclient.registerservicenotificationfilterasync?view=azure-dotnet) The registration mechanism is used inside the dotnet implementation of [servicepartitionresolver](https://learn.microsoft.com/en-us/dotnet/api/microsoft.servicefabric.services.client.servicepartitionresolver?view=azure-dotnet) The registered service to get notification will no longer need to pass the previous endpoint resolve result to force a refresh. This is tested in the stateful example app. But the notification seems to be not very fast (lag of a couple of seconds). But this notification utilizes FabricClient cache, and reduces the cluster api load. I will compare with direct resolution next.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We need to implement a resolver on top of the fabric client similarliy in csharp: ServicePartitionResolver Class (Microsoft.ServiceFabric.Services.Client) - Azure for .NET Developers | Microsoft Learn
Reference: service-fabric-services-and-actors-dotnet/src/Microsoft.ServiceFabric.Services/Client/ServicePartitionResolver.cs at 6f7dc80b1f8e498df3bf2e1b0c41e75bc9ee9862 · microsoft/service-fabric-services-and-actors-dotnet (github.com)
"
Service instances or replicas can move around from node to node at any time for multiple reasons. The service address resolved through ServicePartitionResolver may be stale by the time your client code attempts to connect. In that case again the client needs to re-resolve the address. Providing the previous
ResolvedServicePartition
indicates that the resolver needs to try again rather than simply retrieve a cached address."
The resolver needs to handle stale endpoint entry and register notification callbacks.
The text was updated successfully, but these errors were encountered: