Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Package Change Callbacks in FabricClient #97

Open
cgettys-microsoft opened this issue Nov 15, 2024 · 1 comment
Open

Support for Package Change Callbacks in FabricClient #97

cgettys-microsoft opened this issue Nov 15, 2024 · 1 comment

Comments

@cgettys-microsoft
Copy link
Contributor

My project needs Config package change notifications.

I'm assuming Code Package and Data Package will be useful to others as well, and the implementations are identical except for the type of the package (method signatures otherwise identical, in other words).

So I'm happy to implement all 3.
Probably should also support Config package triggering the config-rs implementation to reload config, but I don't personally need that, so I don't intend to take that on at present.

@cgettys-microsoft
Copy link
Contributor Author

More specifically, the 3 interfaces that should have convenient high level wrappers as part of FabricClient (unless there's a better place for them) are:

  • IFabricCodePackageEventHandler
  • IFabricDataPackageChangeHandler
  • IFabricConfigurationPackageChangeHandler

youyuanwu pushed a commit that referenced this issue Dec 28, 2024
End user applications probably want to handle package change
notifications.

This PR currently tackles only ConfigurationPackage.

If you're happy with the approach, I'll do the same exact implementation
(edit: in additional PRs) for CodePackage and DataPackage and that will
close out #97.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant