Skip to content

Commit

Permalink
Fix Azure Login in pr-check (#171)
Browse files Browse the repository at this point in the history
* Don't use AZURE_CREDENTIALS

* Add workflow permissions

* Fix secrets names
  • Loading branch information
zijchen authored Mar 10, 2023
1 parent a5476bf commit 36c52fa
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion .github/workflows/pr-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ on:
paths:
- '.github/workflows/pr-check.yml'

permissions:
id-token: write # This is needed for Azure login with OIDC

jobs:
deploy:
environment: Automation test # this environment requires approval before running the action
Expand Down Expand Up @@ -45,7 +48,9 @@ jobs:
- name: Azure Login
uses: azure/login@v1
with:
creds: ${{ secrets.AZURE_CREDENTIALS }}
client-id: ${{ secrets.AZURE_CLIENT_ID }}
tenant-id: ${{ secrets.AZURE_TENANT_ID }}
subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}

# Deploy a DACPAC with only a table to server
- name: Test DACPAC Action
Expand Down

0 comments on commit 36c52fa

Please sign in to comment.