Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better state management for all webviews #267

Open
peterbom opened this issue Oct 13, 2023 · 0 comments
Open

Better state management for all webviews #267

peterbom opened this issue Oct 13, 2023 · 0 comments
Labels
enhancement 🚀 New feature or request or improvements on existing code.

Comments

@peterbom
Copy link
Contributor

We recently added the retainContextWhenHidden property to all our webviews.

First, this has the documented drawback that it "has high memory overhead and should only be used when other persistence techniques will not work". We should make an informed decision whether to change this, preferably based on measured memory usage.

Second, you apparently "cannot send messages to a hidden webview". This could be a problem for some of our webviews that perform background operations in VS Code and send updates to the UI (e.g. Periscope, ASO installation, and Create Cluster). We need to test what the current behaviour is, and see whether it needs fixing. If it does, we might be able to build some caching/buffering of messages into our state management approach.

@peterbom peterbom converted this from a draft issue Oct 13, 2023
@Tatsinnit Tatsinnit added the enhancement 🚀 New feature or request or improvements on existing code. label Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🚀 New feature or request or improvements on existing code.
Projects
Development

No branches or pull requests

2 participants