Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the draft binary for GitHub workflow file generation #762

Open
peterbom opened this issue Jun 25, 2024 · 0 comments
Open

Use the draft binary for GitHub workflow file generation #762

peterbom opened this issue Jun 25, 2024 · 0 comments

Comments

@peterbom
Copy link
Contributor

This extension does not currently use Draft's generate-workflow command to generate GitHub workflow files.

The reasoning is that Draft is not sufficiently configurable to support workflow generation comparable to Automated Deployments. Specifically, it does not support:

  • specifying the workflow name (will be addressed by #324)
  • specifying different resource groups for ACR and cluster (will be addressed by #324)
  • specifying the cluster namespace to deploy to (will be addressed by #324)
  • manifest files in a location other than manifests within the project root (see: #325), making it unsuitable for repositories containing more than one service
  • specifying multiple manifest files (see: #325)

After these are addressed in Draft, the workflow generation can be simplified by invoking the Draft binary and removing the template files.

@Tatsinnit Tatsinnit added bug Something isn't working and removed bug Something isn't working labels Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants