Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

num_measurements calculation is wrong when measurements are not simultaneous #82

Open
blakejohnson opened this issue Oct 5, 2016 · 1 comment
Open

num_measurements calculation is wrong when measurements are not simultaneous #82

blakejohnson opened this issue Oct 5, 2016 · 1 comment
Assignees
@blakejohnson
Labels
bug

Comments

@blakejohnson
Copy link
Collaborator

For example:

[MEAS(q1)*MEAS(q2)]

we count as 1 measurement, but

[MEAS(q1), MEAS(q2)]

we count as 2 measurements. The num_measurements calculation should probably be done on a per channel basis. Then we have the new problem of choosing a value when the number of measurements is not uniform over the set of channels, but requires more infrastructure to solve.

cc @dieris
@blakejohnson blakejohnson self-assigned this Oct 5, 2016
blakejohnson added a commit that referenced this issue Oct 6, 2016
@blakejohnson
Improve measurement counting algorithm.
1a7bd8a 
Fixes issue #82.

Counts the number of measurements per "wire" and takes the max over the wires
for each sequence. Eventually we'd like to skip the `max` reduction and keep the
individual wire values.
@blakejohnson blakejohnson mentioned this issue Oct 6, 2016
Merged
@blakejohnson
Copy link
Collaborator Author

Note that Diego mentioned one more case to fix in #83.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blakejohnson blakejohnson

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@blakejohnson