Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more diagnostic when server is not recognized #178

Open
prjemian opened this issue Oct 2, 2023 · 0 comments
Open

Add more diagnostic when server is not recognized #178

prjemian opened this issue Oct 2, 2023 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@prjemian
Copy link
Contributor

prjemian commented Oct 2, 2023

@padraic-shafer reports (on Mattermost)

that all of the NSLS2 beamline catalogs are unsupported right now.

...

I see...it does not like that the catalogs do not specify any specs.

gemviz/gemviz/mainwindow.py

Lines 102 to 106 in ffb2e5e

try:
spec = specs[0]
spec_name = f"{spec.name}, v{spec.version}"
except IndexError:
spec_name = "not supported now"

INFO:gemviz.mainwindow:Status: Selected catalog 'amx'.
DEBUG:gemviz.mainwindow:specs=ListView([])
DEBUG:gemviz.mainwindow:structure_family=container
INFO:gemviz.mainwindow:Status: catalog 'amx' is 'not supported now'

Thanks for the report @padraic-shafer! We can report more details in such situations. In this case, we'd report that there were no specs available. Documentation (also TBA) could inform what are these specs, for example.

@prjemian prjemian added the enhancement New feature or request label Oct 2, 2023
@prjemian prjemian added this to the v1.1 milestone Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant