Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Show Past Events Toggle on Past Terms #1389

Open
wants to merge 4 commits into
base: development
Choose a base branch
from
Open

Fixed Show Past Events Toggle on Past Terms #1389

wants to merge 4 commits into from

Conversation

bledsoef
Copy link
Contributor

@bledsoef bledsoef commented Jan 30, 2025 •
edited
Loading

Issue Description

Closes #1372

  • If you untoggle "Show Past Events" and then switch to a past term, it will maintain that change and you won't be able to see any events.

Changes

  • Added a conditional that checks if it is a current term and if it is not it will ignore whatever is stored in the session state, which was causing the problem in the first place.
  • Renamed event_list.js to be eventList.js

Testing

  • Replicate issue on development
  • Reset database, source setup.sh, etc.
  • Disable "Show Past Events" on the Event List.
  • Switch to a past term and make sure it is enabled again.
  • Return to a current or future term and make sure it restores to the state it was before.
  • Merge :)

@bledsoef bledsoef requested review from Kafui123 and removed request for Kafui123 January 30, 2025 22:16
@MImran2002
Copy link
Contributor

Just like what Finn said, the function of the past events and the toggle buttons are owrking well. The button also toggle and untoggle depending on whether the year selected is past or future.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2025

View Code Coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bledsoef bledsoef

@Kafui123 Kafui123

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Events List - View Past Events Toggle
3 participants
@bledsoef @MImran2002 @Kafui123