Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Might it be useful & explicit to specify in "Help me choose" that the default unestimated unit vector of groupSizes in XML is okay? #2

Open
MordorianGuy opened this issue Sep 10, 2023 · 0 comments

Comments

@MordorianGuy
Copy link

MordorianGuy commented Sep 10, 2023

I noticed that I have a unit vector of groupSizes in my model XML. I was confounded since it is stated that the value should be taxa_n // 10 (except in extreme cases, of course), and the input has the estimate="false" attribute. Only when I read the source code, I noticed comments explaining that it is okay and the appropriate default values are calculated during the initialisation, but it is not obvious from the "Help me choose" description.

            if (eventsCovered == 0 || eventsCovered == paramDim2) {
                // For these special cases we assume that the XML has not
                // specified initial group sizes
                // or has set all to 1 and we set them here automatically...

Best regards,

@MordorianGuy MordorianGuy changed the title Might it be useful & explicit to specify that Might it be useful & explicit to specify in "Help me choose" that the default unestimated unit vector of groupSizes in XML is okay? Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant