Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAJOR WildTools issue #210

Closed
JHarris12345 opened this issue Oct 25, 2024 · 6 comments
Closed

MAJOR WildTools issue #210

JHarris12345 opened this issue Oct 25, 2024 · 6 comments
Assignees
Labels
✔️ Confirmed Confirmed bugs that can be replicated 🔧 Potential fix A potential fix was already submitted

Comments

@JHarris12345
Copy link

JHarris12345 commented Oct 25, 2024

Minecraft's Version

1.21.1

Plugin's Version

2024.3-b52

Describe the bug

The plugin can accidentally register enchants more than once and prevent players from joining until a restart. Here is a client log:

https://pastes.dev/qJEQk4Etil

It should be made so if the enchant is already registered, it doesn't register it again. The ViaVersion dev said this:

"Uhh not sure, Paper has proper API to register them once but it doesn't look like it's using API"

To Reproduce

Not 100% sure

Additional Information

No response

@JHarris12345 JHarris12345 added the Pending Pending reports to be investigated label Oct 25, 2024
@JHarris12345
Copy link
Author

I will say, this only prevents 1.21.2 and 1.21.3 clients from joining when this error occurs. If you want a definitive and easy way to replicate it, simply /plugman reload the plugin :)

@JHarris12345
Copy link
Author

Also since I dont use the glowing enchant, can you make it configurable if it even tries to register at ALL. Because I will disable this entirely so it doesnt cause me issues

@OmerBenGera
Copy link
Member

Reloads of the plugin are not supported.
If you dont reload it, does it still happen?

@JHarris12345
Copy link
Author

If you could just make a config option to register the enchantment that would be amazing thank you!

@OmerBenGera OmerBenGera added ✔️ Confirmed Confirmed bugs that can be replicated and removed Pending Pending reports to be investigated labels Oct 26, 2024
@OmerBenGera OmerBenGera added the 🔧 Potential fix A potential fix was already submitted label Oct 26, 2024
@OmerBenGera
Copy link
Member

It is fixed in latest dev build.
I still do not recommend reloading the plugin, it is an unsupported behavior.

@JHarris12345
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✔️ Confirmed Confirmed bugs that can be replicated 🔧 Potential fix A potential fix was already submitted
Projects
None yet
Development

No branches or pull requests

2 participants