Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem when have more that one catch all route #148

Open
AdrianSkierniewski opened this issue Mar 16, 2017 · 0 comments
Open

Problem when have more that one catch all route #148

AdrianSkierniewski opened this issue Mar 16, 2017 · 0 comments

Comments

@AdrianSkierniewski
Copy link

Hi,

I'm using Laravel 5.3 and I wanted to use Croppa in my current project (I used it with Laravel 4 before :)), but I encountered one issue. Croppa registers its route in service provider boot method and this method is triggered after loading route files, so if you have a catch-all route in your route files (for example cms router that needs to catch all URLs and check if they're in DB) Croppa route won't be trigger at all.
I quickly checked if moving this route definition to register method will solve this issue and it will work, but then I started thinking.
Why do we even need to register this route in ServiceProvider? Maybe it will be better to leave it as part of setup so everyone can decide where they want to add it, especially that now Laravel have more that one route file (web, api).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant