Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how it's intended to be used (wrapped in transition) #3

Open
mattaebersold opened this issue Nov 1, 2021 · 1 comment
Open

Comments

@mattaebersold
Copy link
Collaborator

It wasn't clear at first glance that I was intending this to be wrapped in a transition element with a v-show where you control that logic outside of vue-modal

@weotch
Copy link
Member

weotch commented Nov 2, 2021

Adding a demo using create-cloak-app would be 😘 👌 ... also, I think using v-if would be preferable to reduce the JS cost ... like so Vue doesn't do any work until the modal is actually opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants