-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SuPy tutorial #20
Comments
Great job Ting. Here are some suggestions: 1- It would be good to have a brief explanation about SuPy in the notebook itself and then redirect to the SuPy manual site 2- In 1.1.2 it talks about land cover fraction but it prints out the tree and building hight information 3- Maybe more explanation when modifying the surface fraction of AR1: saying because it is a grassland, we put all into grassland and the rest zero 4- Maybe disabling QF by putting the emisionmethod=0 rather than population density=0? 5- Validating df_state could be confusing for students. Maybe either we should give more explanation or just remove it 6- Maybe water balance part will be confusing for students as they did not work on them in the clasee 7- Some of the plots at the end RS versus variables looks very confusing specially the ones with lots of dots. Is there other ways to represent them? 8- We should encourage them to install table of contents for the notebook as it makes it much easier to redirect in the notebook specially for this one |
Many thanks, Hamid: Very helpful comments! |
Nice work. Lots of great stuff here. Almost everything worked on my Windows machine.
|
Thanks very much, Todd! |
Hi @hamidrezaomidvar @trjr, I prepared a SuPy tutorial here:
https://github.com/BLM-UoR/BLM/blob/master/docs/tutorials/tutorial-AMF-sim.ipynb
Could you please help with testing?
Hi @suegrimmond, please comment on pieces that I might have missed in this draft.
Thank you all!
The text was updated successfully, but these errors were encountered: