Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SuPy tutorial #20

Open
sunt05 opened this issue Nov 19, 2019 · 4 comments
Open

SuPy tutorial #20

sunt05 opened this issue Nov 19, 2019 · 4 comments

Comments

@sunt05
Copy link
Contributor

sunt05 commented Nov 19, 2019

Hi @hamidrezaomidvar @trjr, I prepared a SuPy tutorial here:
https://github.com/BLM-UoR/BLM/blob/master/docs/tutorials/tutorial-AMF-sim.ipynb

Could you please help with testing?

Hi @suegrimmond, please comment on pieces that I might have missed in this draft.

Thank you all!

@hamidrezaomidvar
Copy link
Contributor

Great job Ting. Here are some suggestions:

1- It would be good to have a brief explanation about SuPy in the notebook itself and then redirect to the SuPy manual site

2- In 1.1.2 it talks about land cover fraction but it prints out the tree and building hight information

3- Maybe more explanation when modifying the surface fraction of AR1: saying because it is a grassland, we put all into grassland and the rest zero

4- Maybe disabling QF by putting the emisionmethod=0 rather than population density=0?

5- Validating df_state could be confusing for students. Maybe either we should give more explanation or just remove it

6- Maybe water balance part will be confusing for students as they did not work on them in the clasee

7- Some of the plots at the end RS versus variables looks very confusing specially the ones with lots of dots. Is there other ways to represent them?

8- We should encourage them to install table of contents for the notebook as it makes it much easier to redirect in the notebook specially for this one

@sunt05
Copy link
Contributor Author

sunt05 commented Nov 19, 2019

Many thanks, Hamid: Very helpful comments!
I'll wait for others' comments and revise it later.

@trjr
Copy link
Collaborator

trjr commented Nov 19, 2019

Nice work. Lots of great stuff here. Almost everything worked on my Windows machine.

  1. For Windows machines, the redirect to null for the supy install should be like this:
    !pip install supy==2019.11.18.dev0 > nul 2>&1
  2. While links to more detailed references are provided, it would be helpful to the students to provide very short descriptions of the surface parameter terms. For instance, I doubt anyone will know what sddfull is. On the other hand, maybe they don't need to know?? Comments like that under urban feature would be appropriate.
  3. Agree with @hamidrezaomidvar regarding the need for a description of sp.checkstate(df_state_amf).
  4. In text intro to Run simulations, df_state should be df_state_final.
  5. Explicitly define SMD before it is used.

@sunt05
Copy link
Contributor Author

sunt05 commented Nov 19, 2019

Thanks very much, Todd!
In particular the comments on redirecting on Windows, which would be very helpful.
I’ll post a revised version later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants