Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change retrials -> retries #2088

Open
dbeltrankyl opened this issue Jan 30, 2025 · 2 comments
Open

Change retrials -> retries #2088

dbeltrankyl opened this issue Jan 30, 2025 · 2 comments
Labels
discussion The issue is created to keep track a discussion documentation Improvements or additions to documentation
Milestone

Comments

@dbeltrankyl
Copy link
Contributor

Hello @BSC-ES/autosubmit

From @tiggi, mattermost:

Whoever touches autosubmit code: retrial and retry are completely different things. AS code is full of references to retrial in both log messages and as variable names. It does not mean what you think it means.

For a retrial you go back to court and redo the original trial.

https://en.wiktionary.org/w/index.php?title=retrial&rdfrom=Retrial

So, we have to change retrials -> retries everywhere.

This means that some exportable variables need to be renamed as well. To avoid breaking anything, I propose doing it for 4.2+.

@dbeltrankyl dbeltrankyl added discussion The issue is created to keep track a discussion documentation Improvements or additions to documentation labels Jan 30, 2025
@dbeltrankyl dbeltrankyl added this to the 4.2.0 milestone Jan 30, 2025
@kinow
Copy link
Member

kinow commented Jan 30, 2025

+1 for 4.2. Maybe we could support both for a while, but raise a deprecation warning telling users to update to the new value.

@dbeltrankyl dbeltrankyl modified the milestones: 4.2.0, 4.1.12 Jan 30, 2025
@tiggi
Copy link

tiggi commented Jan 30, 2025

#2090

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion The issue is created to keep track a discussion documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants