You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Found while testing #2123 for @orioltinto. I had an autosubmit create a000 && autosubmit inspect a000, and the RHS part was not being evaluated.
I checked and autosubmit create was not logging any errors but it was returning 1. Looking at the code, it's because def create(...) returns a bool instead of an int. Enabling mypy + type hints might be the cheapest way to find issues like this, or we review everything or write tests for the missing parts.
I have the fix done locally, but will prepare a small test later and submit a pull request (will focus on #2104 as that has higher priority).
The text was updated successfully, but these errors were encountered:
Found while testing #2123 for @orioltinto. I had an
autosubmit create a000 && autosubmit inspect a000
, and the RHS part was not being evaluated.I checked and
autosubmit create
was not logging any errors but it was returning1
. Looking at the code, it's becausedef create(...)
returns a bool instead of an int. Enabling mypy + type hints might be the cheapest way to find issues like this, or we review everything or write tests for the missing parts.I have the fix done locally, but will prepare a small test later and submit a pull request (will focus on #2104 as that has higher priority).
The text was updated successfully, but these errors were encountered: