Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autosubmit create returning 1 even though it succeeds #2124

Open
kinow opened this issue Feb 11, 2025 · 1 comment · May be fixed by #2125
Open

autosubmit create returning 1 even though it succeeds #2124

kinow opened this issue Feb 11, 2025 · 1 comment · May be fixed by #2125
Assignees
Labels
bug Something isn't working
Milestone

Comments

@kinow
Copy link
Member

kinow commented Feb 11, 2025

Found while testing #2123 for @orioltinto. I had an autosubmit create a000 && autosubmit inspect a000, and the RHS part was not being evaluated.

I checked and autosubmit create was not logging any errors but it was returning 1. Looking at the code, it's because def create(...) returns a bool instead of an int. Enabling mypy + type hints might be the cheapest way to find issues like this, or we review everything or write tests for the missing parts.

I have the fix done locally, but will prepare a small test later and submit a pull request (will focus on #2104 as that has higher priority).

@kinow kinow added the bug Something isn't working label Feb 11, 2025
@kinow kinow added this to the 4.1.12 milestone Feb 11, 2025
@kinow kinow linked a pull request Feb 11, 2025 that will close this issue
@kinow
Copy link
Member Author

kinow commented Feb 11, 2025

Looks like there are other functions of commands that also return bool, while some still return int...

@kinow kinow self-assigned this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant