Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TpllCommand.java: Fix the offset being applied twice #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tf2mandeokyi
Copy link

Why apply offset again when it is already applied

Also this causes a chunk system error when the offset is not (0, 0, 0)

[16:58:48] [Tuinity Chunk System Worker #2/ERROR]: [ChunkTaskScheduler] Chunk system error at chunk (~~~,~~~), holder: NewChunkHolder{world=~~~, chunkX=~~~, chunkZ=~~~, entityChunkFromDisk=false, lastChunkCompletion={chunk_class=net.minecraft.world.level.chunk.ProtoChunk,status=minecraft:structure_references}, currentGenStatus=minecraft:structure_references, requestedGenStatus=minecraft:full, generationTask=ChunkProgressionTask{class: io.papermc.paper.chunk.system.scheduling.ChunkUpgradeGenericStatusTask, for world: ~~~, chunk: (~~~,~~~), hashcode: 1779680793, priority: COMPLETING, status: minecraft:biomes, scheduled: true}, generationTaskStatus=minecraft:biomes, priority=HIGHER, priorityLocked=false, neighbourRequestedPriority=IDLE, effective_priority=HIGHER, oldTicketLevel=33, currentTicketLevel=33, totalNeighboursUsingThisChunk=4, fullNeighbourChunksLoadedBitset=0, chunkStatusRaw=0, currentChunkStatus=INACCESSIBLE, pendingChunkStatus=INACCESSIBLE, is_unload_safe=ticket_level, killed=false}, exception:
java.lang.Throwable: java.util.concurrent.CompletionException: java.lang.RuntimeException: net.buildtheearth.terraminusminus.projection.OutOfProjectionBoundsException
	at io.papermc.paper.chunk.system.scheduling.ChunkTaskScheduler.unrecoverableChunkSystemFailure(ChunkTaskScheduler.java:279) ~[paper-1.20.4.jar:git-Paper-381]
	at io.papermc.paper.chunk.system.scheduling.NewChunkHolder.lambda$setGenerationTask$4(NewChunkHolder.java:1700) ~[paper-1.20.4.jar:git-Paper-381]
	at io.papermc.paper.chunk.system.scheduling.ChunkProgressionTask.complete0(ChunkProgressionTask.java:95) ~[paper-1.20.4.jar:git-Paper-381]
	at io.papermc.paper.chunk.system.scheduling.ChunkProgressionTask.complete(ChunkProgressionTask.java:75) ~[paper-1.20.4.jar:git-Paper-381]
	at io.papermc.paper.chunk.system.scheduling.ChunkUpgradeGenericStatusTask.run(ChunkUpgradeGenericStatusTask.java:139) ~[paper-1.20.4.jar:git-Paper-381]
	at ca.spottedleaf.concurrentutil.executor.standard.PrioritisedThreadedTaskQueue$PrioritisedTask.executeInternal(PrioritisedThreadedTaskQueue.java:351) ~[paper-1.20.4.jar:git-Paper-381]
	at ca.spottedleaf.concurrentutil.executor.standard.PrioritisedThreadedTaskQueue.executeTask(PrioritisedThreadedTaskQueue.java:118) ~[paper-1.20.4.jar:git-Paper-381]
	at ca.spottedleaf.concurrentutil.executor.standard.PrioritisedThreadPool$PrioritisedThread.pollTasks(PrioritisedThreadPool.java:274) ~[paper-1.20.4.jar:git-Paper-381]
	at ca.spottedleaf.concurrentutil.executor.standard.PrioritisedQueueExecutorThread.run(PrioritisedQueueExecutorThread.java:62) ~[paper-1.20.4.jar:git-Paper-381]
Caused by: java.util.concurrent.CompletionException: java.lang.RuntimeException: net.buildtheearth.terraminusminus.projection.OutOfProjectionBoundsException
	at java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:315) ~[?:?]
	at java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:320) ~[?:?]
	at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1770) ~[?:?]
	at java.util.concurrent.CompletableFuture.asyncSupplyStage(CompletableFuture.java:1782) ~[?:?]
	at java.util.concurrent.CompletableFuture.supplyAsync(CompletableFuture.java:2005) ~[?:?]
	at net.minecraft.world.level.chunk.ChunkGenerator.createBiomes(ChunkGenerator.java:114) ~[paper-1.20.4.jar:git-Paper-381]
	at net.minecraft.world.level.chunk.ChunkStatus.lambda$static$6(ChunkStatus.java:84) ~[paper-1.20.4.jar:git-Paper-381]
	at net.minecraft.world.level.chunk.ChunkStatus.generate(ChunkStatus.java:259) ~[paper-1.20.4.jar:git-Paper-381]
	at io.papermc.paper.chunk.system.scheduling.ChunkUpgradeGenericStatusTask.run(ChunkUpgradeGenericStatusTask.java:86) ~[paper-1.20.4.jar:git-Paper-381]
	... 4 more
Caused by: java.lang.RuntimeException: net.buildtheearth.terraminusminus.projection.OutOfProjectionBoundsException
	at de.btegermany.terraplusminus.data.TerraConnector.toGeo(TerraConnector.java:31) ~[terraplusminus-1.3.2.jar:?]
	at de.btegermany.terraplusminus.gen.CustomBiomeProvider.getBiome(CustomBiomeProvider.java:30) ~[terraplusminus-1.3.2.jar:?]
	at org.bukkit.generator.BiomeProvider.getBiome(BiomeProvider.java:61) ~[paper-api-1.20.4-R0.1-SNAPSHOT.jar:?]
	at org.bukkit.craftbukkit.v1_20_R3.generator.CustomWorldChunkManager.getNoiseBiome(CustomWorldChunkManager.java:47) ~[paper-1.20.4.jar:git-Paper-381]
	at net.minecraft.world.level.chunk.LevelChunkSection.fillBiomesFromNoise(LevelChunkSection.java:235) ~[?:?]
	at net.minecraft.world.level.chunk.ChunkAccess.fillBiomesFromNoise(ChunkAccess.java:535) ~[?:?]
	at net.minecraft.world.level.chunk.ChunkGenerator.lambda$createBiomes$3(ChunkGenerator.java:115) ~[paper-1.20.4.jar:git-Paper-381]
	at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1768) ~[?:?]
	at java.util.concurrent.CompletableFuture.asyncSupplyStage(CompletableFuture.java:1782) ~[?:?]
	at java.util.concurrent.CompletableFuture.supplyAsync(CompletableFuture.java:2005) ~[?:?]
	at net.minecraft.world.level.chunk.ChunkGenerator.createBiomes(ChunkGenerator.java:114) ~[paper-1.20.4.jar:git-Paper-381]
	at net.minecraft.world.level.chunk.ChunkStatus.lambda$static$6(ChunkStatus.java:84) ~[paper-1.20.4.jar:git-Paper-381]
	at net.minecraft.world.level.chunk.ChunkStatus.generate(ChunkStatus.java:259) ~[paper-1.20.4.jar:git-Paper-381]
	at io.papermc.paper.chunk.system.scheduling.ChunkUpgradeGenericStatusTask.run(ChunkUpgradeGenericStatusTask.java:86) ~[paper-1.20.4.jar:git-Paper-381]
	... 4 more

Fix the command re-applying the offset
@tf2mandeokyi tf2mandeokyi changed the title Update TpllCommand.java Update TpllCommand.java: Fix the offset being applied twice Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant