Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toptal/chewy v7.0.1 #5

Merged
merged 16 commits into from
Nov 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ jobs:
rspec-ruby-26-activerecord52:
docker:
- image: circleci/ruby:2.6
- image: docker.elastic.co/elasticsearch/elasticsearch:5.6.7
- image: docker.elastic.co/elasticsearch/elasticsearch:7.10.1
environment:
<<: *es-env
working_directory: ~/repo
Expand All @@ -120,7 +120,7 @@ jobs:
rspec-ruby-26-activerecord60:
docker:
- image: circleci/ruby:2.6
- image: docker.elastic.co/elasticsearch/elasticsearch:5.6.7
- image: docker.elastic.co/elasticsearch/elasticsearch:7.10.1
environment:
<<: *es-env
working_directory: ~/repo
Expand All @@ -132,7 +132,7 @@ jobs:
rspec-ruby-26-activerecord61:
docker:
- image: circleci/ruby:2.6
- image: docker.elastic.co/elasticsearch/elasticsearch:5.6.7
- image: docker.elastic.co/elasticsearch/elasticsearch:7.10.1
environment:
<<: *es-env
working_directory: ~/repo
Expand All @@ -145,7 +145,7 @@ jobs:
docker:
- image: circleci/ruby:2.6
- image: circleci/mongo:4.2.5
- image: docker.elastic.co/elasticsearch/elasticsearch:5.6.7
- image: docker.elastic.co/elasticsearch/elasticsearch:7.10.1
environment:
<<: *es-env
working_directory: ~/repo
Expand All @@ -157,7 +157,7 @@ jobs:
rspec-ruby-27-activerecord52:
docker:
- image: circleci/ruby:2.7
- image: docker.elastic.co/elasticsearch/elasticsearch:5.6.7
- image: docker.elastic.co/elasticsearch/elasticsearch:7.10.1
environment:
<<: *es-env
working_directory: ~/repo
Expand All @@ -169,7 +169,7 @@ jobs:
rspec-ruby-27-activerecord60:
docker:
- image: circleci/ruby:2.7
- image: docker.elastic.co/elasticsearch/elasticsearch:5.6.7
- image: docker.elastic.co/elasticsearch/elasticsearch:7.10.1
environment:
<<: *es-env
working_directory: ~/repo
Expand All @@ -181,7 +181,7 @@ jobs:
rspec-ruby-27-activerecord61:
docker:
- image: circleci/ruby:2.7
- image: docker.elastic.co/elasticsearch/elasticsearch:5.6.7
- image: docker.elastic.co/elasticsearch/elasticsearch:7.10.1
environment:
<<: *es-env
working_directory: ~/repo
Expand All @@ -194,7 +194,7 @@ jobs:
docker:
- image: circleci/ruby:2.7
- image: circleci/mongo:4.2.5
- image: docker.elastic.co/elasticsearch/elasticsearch:5.6.7
- image: docker.elastic.co/elasticsearch/elasticsearch:7.10.1
environment:
<<: *es-env
working_directory: ~/repo
Expand All @@ -206,7 +206,7 @@ jobs:
rspec-ruby-30-activerecord61:
docker:
- image: circleci/ruby:3.0
- image: docker.elastic.co/elasticsearch/elasticsearch:5.6.7
- image: docker.elastic.co/elasticsearch/elasticsearch:7.10.1
environment:
<<: *es-env
working_directory: ~/repo
Expand Down
39 changes: 39 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
---
name: Bug Report
about: Report an issue with Chewy you've discovered.
---

*Be clear, concise and precise in your description of the problem.
Open an issue with a descriptive title and a summary in grammatically correct,
complete sentences.*

*Use the template below when reporting bugs. Please, make sure that
you're running the latest stable Chewy and that the problem you're reporting
hasn't been reported (and potentially fixed) already.*

*Before filing the ticket you should replace all text above the horizontal
rule with your own words.*

--------

## Expected behavior

Describe here how you expected Chewy to behave in this particular situation.

## Actual behavior

Describe here what actually happened.

## Steps to reproduce the problem

This is extremely important! Providing us with a reliable way to reproduce
a problem will expedite its solution.

## Version Information

Share here essential version information such as:

* Chewy version
* Elasticsearch version
* Ruby version
* Rails version
20 changes: 20 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
---
name: Feature Request
about: Suggest new Chewy features or improvements to existing features.
---

## Is your feature request related to a problem? Please describe.

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

## Describe the solution you'd like

A clear and concise description of what you want to happen.

## Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

## Additional context

Add any other context or screenshots about the feature request here.
16 changes: 16 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
**Replace this text with a summary of the changes in your PR.
The more detailed you are, the better.**

-----------------

Before submitting the PR make sure the following are checked:

* [ ] The PR relates to *only* one subject with a clear title and description in grammatically correct, complete sentences.
* [ ] Wrote [good commit messages][1].
* [ ] Commit message starts with `[Fix #issue-number]` (if the related issue exists).
* [ ] Feature branch is up-to-date with `master` (if not - rebase it).
* [ ] Squashed related commits together.
* [ ] Added tests.
* [ ] Added an entry to the changelog if the new code introduces user-observable changes. See [changelog entry format](https://github.com/toptal/chewy/blob/master/CONTRIBUTING.md#changelog-entry-format) for details.

[1]: https://chris.beams.io/posts/git-commit/
94 changes: 94 additions & 0 deletions .github/workflows/ruby.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,94 @@
name: CI

on: [push]

jobs:
tests:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
ruby: [2.6, 2.7]
gemfile: [rails.5.2.activerecord, rails.6.0.activerecord, rails.6.1.activerecord]
name: ${{ matrix.ruby }}-${{ matrix.gemfile }}

env:
BUNDLE_GEMFILE: gemfiles/${{ matrix.gemfile }}.gemfile

steps:
- uses: actions/checkout@v2
- uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
bundler-cache: true
- name: Run Elasticsearch
uses: elastic/elastic-github-actions/elasticsearch@master
with:
stack-version: 7.10.1
port: 9250
- name: Tests
run: bundle exec rspec

ruby-3-0-activerecord-6-1:
runs-on: ubuntu-latest
env:
BUNDLE_GEMFILE: gemfiles/rails.6.1.activerecord.gemfile
steps:
- uses: actions/checkout@v2
- uses: ruby/setup-ruby@v1
with:
ruby-version: '3.0'
bundler-cache: true
- name: Run Elasticsearch
uses: elastic/elastic-github-actions/elasticsearch@master
with:
stack-version: 7.10.1
port: 9250
- name: Tests
run: bundle exec rspec

ruby-3-0-activerecord-6-1-es6:
runs-on: ubuntu-latest
env:
BUNDLE_GEMFILE: gemfiles/rails.6.1.activerecord.gemfile
steps:
- uses: actions/checkout@v2
- uses: ruby/setup-ruby@v1
with:
ruby-version: '3.0'
bundler-cache: true
- name: Run Elasticsearch
uses: elastic/elastic-github-actions/elasticsearch@master
with:
stack-version: 6.8.15
port: 9250
- name: Tests
run: bundle exec rspec

ruby-2-7-activerecord-6-1-es6:
runs-on: ubuntu-latest
env:
BUNDLE_GEMFILE: gemfiles/rails.6.1.activerecord.gemfile
steps:
- uses: actions/checkout@v2
- uses: ruby/setup-ruby@v1
with:
ruby-version: 2.7
bundler-cache: true
- name: Run Elasticsearch
uses: elastic/elastic-github-actions/elasticsearch@master
with:
stack-version: 6.8.15
port: 9250
- name: Tests
run: bundle exec rspec

rubocop:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: ruby/setup-ruby@v1
with:
ruby-version: 2.7
bundler-cache: true
- run: bundle exec rubocop --format simple
Loading
Loading