Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[개선] 원서 조회, 원서 상세 조회 수정 #93

Merged
merged 2 commits into from
Jul 6, 2024
Merged

[개선] 원서 조회, 원서 상세 조회 수정 #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e1a072
feat(#92): Response에 examinationNumber 필드 추가
cabbage16 Jul 6, 2024
07576ad
test(#92): FormFixture에 examinationNumber 추가
cabbage16 Jul 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/main/java/com/bamdoliro/maru/presentation/form/dto/response/FormResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
public class FormResponse {

private Long id;
private Long examinationNumber;
private ApplicantResponse applicant;
private ParentResponse parent;
private EducationResponse education;
Expand All @@ -22,6 +23,7 @@ public class FormResponse {

public FormResponse(Form form) {
this.id = form.getId();
this.examinationNumber = form.getExaminationNumber();
this.applicant = new ApplicantResponse(form.getApplicant());
this.parent = new ParentResponse(form.getParent());
this.education = new EducationResponse(form.getEducation());
Expand Down
2 changes: 2 additions & 0 deletions src/main/java/com/bamdoliro/maru/presentation/form/dto/response/FormSimpleResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
public class FormSimpleResponse {

private Long id;
private Long examinationNumber;
private String name;
private LocalDate birthday;
private GraduationType graduationType;
Expand All @@ -28,6 +29,7 @@ public class FormSimpleResponse {

public FormSimpleResponse(Form form) {
this.id = form.getId();
this.examinationNumber = form.getExaminationNumber();
this.name = form.getApplicant().getName();
this.birthday = form.getApplicant().getBirthday();
this.graduationType = form.getEducation().getGraduationType();
Expand Down
1 change: 1 addition & 0 deletions src/test/java/com/bamdoliro/maru/shared/fixture/FormFixture.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,6 +439,7 @@ public static FormSimpleResponse createFormSimpleResponse(FormStatus status) {
public static FormResponse createFormResponse() {
return new FormResponse(
1L,
2001L,
new ApplicantResponse(
"https://maru.com/photo.png",
"김밤돌",
Expand Down
Loading