Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an easier way to display formatted attributes (perhaps by adding another config entry) #25

Closed
bibi-reden opened this issue Aug 7, 2024 · 1 comment
Assignees
Labels
📃 Documentation Improvements or additions to documentation 🛠️ Fix Meant to resolve an issue/bug in the codebase. 🆘 Help! Extra attention is needed ℹ️ Information Further information is requested 🔎 Investigating The issue/pr is being investigated. 🦐 Minor A minor update to the codebase.

Comments

@bibi-reden
Copy link

preface

The issue is currently, we are all over the place with how an attribute should be formatted.
The original DataAttributes had a properties section related to an attribute how it should be formatted, and some other things.

The benefits of this will allow us to pull from one source for our formatting in the manager and display the attribute correctly to the viewer.

There are two options:

  • Attach to the AttributeOverride a format entry, which points to a way of formatting the Double attribute value (least cumbersome, seems preferrable, will bloat the class a bit).
  • Make an entirely separate entry called properties (have to think of a higher purpose for it, will add another entry to the manager directly)
@bibi-reden bibi-reden added 📃 Documentation Improvements or additions to documentation 🆘 Help! Extra attention is needed ℹ️ Information Further information is requested 🔎 Investigating The issue/pr is being investigated. 🦐 Minor A minor update to the codebase. 🛠️ Fix Meant to resolve an issue/bug in the codebase. labels Aug 7, 2024
@DataEncoded DataEncoded self-assigned this Aug 7, 2024
@DataEncoded
Copy link

FIXED IN #29 o7 o7 o7 o7 o7 o7 o7 o7 o7 tyfys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📃 Documentation Improvements or additions to documentation 🛠️ Fix Meant to resolve an issue/bug in the codebase. 🆘 Help! Extra attention is needed ℹ️ Information Further information is requested 🔎 Investigating The issue/pr is being investigated. 🦐 Minor A minor update to the codebase.
Projects
None yet
Development

No branches or pull requests

2 participants