Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change List<AttributeFunction> to Map<ResourceLocation, AttributeFunction> #27

Closed
bibi-reden opened this issue Aug 9, 2024 · 1 comment · Fixed by #33
Closed

Change List<AttributeFunction> to Map<ResourceLocation, AttributeFunction> #27

bibi-reden opened this issue Aug 9, 2024 · 1 comment · Fixed by #33
Labels
😱 Critical There is a rapid response needed to a vulnerability/problem in the codebase. 🛠️ Fix Meant to resolve an issue/bug in the codebase. 🪄 Major A major update to the codebase.

Comments

@bibi-reden
Copy link

Before release, this needs to happen as there are issues with using this structure. It was used to bypass a config issue but it has concurrency issues and possible duplication problems.
@bibi-reden bibi-reden added 🪄 Major A major update to the codebase. 🛠️ Fix Meant to resolve an issue/bug in the codebase. labels Aug 9, 2024
@bibi-reden bibi-reden changed the title Change List<AttributeFunction> to Map<ResourceLocation, AttributeFunction> Change List<AttributeFunction> to Map<ResourceLocation, AttributeFunction> Aug 9, 2024
@bibi-reden bibi-reden added the 😱 Critical There is a rapid response needed to a vulnerability/problem in the codebase. label Aug 9, 2024
@bibi-reden bibi-reden linked a pull request Sep 26, 2024 that will close this issue
2.0.0+1.20.1 (release) #33
Merged
@bibi-reden bibi-reden removed a link to a pull request Oct 2, 2024
2.0.0+1.20.1 (release) #33
Merged
@bibi-reden
Copy link
Author

It will be done on the 1.21 branch

@bibi-reden bibi-reden linked a pull request Oct 3, 2024 that will close this issue
2.0.0+1.20.1 (release) #33
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
😱 Critical There is a rapid response needed to a vulnerability/problem in the codebase. 🛠️ Fix Meant to resolve an issue/bug in the codebase. 🪄 Major A major update to the codebase.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

2.0.0+1.20.1 (release) BareMinimumStudios/data-attributes
1 participant
@bibi-reden