Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Bug report #4

Open
OferRavid opened this issue Aug 25, 2021 · 4 comments
Open

Issue: Bug report #4

OferRavid opened this issue Aug 25, 2021 · 4 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@OferRavid
Copy link

OferRavid commented Aug 25, 2021

There is a problem in the order in which the charts are being deleted.

The order of chart releases deletion is determined by the order of namespaces, which is determined by the command to get namespaces in line 100 (which as far as I can tell is alphabetical order), and then in each namespace by the order of releases in the list helm_charts, that is created in line 105 (probably also alphabetical), but that can become problematic if release 'a' is in that order before release 'b' but 'b' is dependent on 'a', because after 'a' is deleted 'b' cannot be deleted.

For example:
The chart for cert-manager defines the resource clusterIssuer so any chart that uses that resource can't be deleted after cert-manager, instead you get this error message: " Error: uninstallation completed with 1 error(s): unable to build kubernetes objects for delete: unable to recognize "": no matches for kind "ClusterIssuer" in version "cert-manager.io/v1". "

Edit:
In fact the release is deleted but the resources aren't.

@OferRavid OferRavid changed the title Bug report Issue: Bug report Aug 25, 2021
@BarelElbaz
Copy link
Owner

Our plugin uses the helm native delete command/functionallity. We can try to fix it but it may be a little bit hard.

take a look here (this is the official helm repo)
helm/helm#8413

I think this behavior is specific to Crds but we should do some tests.

@Whitehawk2
Copy link
Collaborator

I'll be adding this to our TODO list, but like Barel said - this seems to be a "feature" or shortcoming of the native helm delete functionallity.

@BarelElbaz - On V2, maybe see if there's a way to find dangling CRDs (and delete them)?

@Whitehawk2 Whitehawk2 added bug Something isn't working wontfix This will not be worked on labels Aug 26, 2021
@Whitehawk2
Copy link
Collaborator

since this is more if a Helm thing, I think we won't work on this (for now!)?

@BarelElbaz
Copy link
Owner

you are right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants