Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Catalyst apps #11

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

raxityo
Copy link
Contributor

@raxityo raxityo commented Feb 1, 2023

This PR lives on top of #9, so leaving this as a draft while #9 is open. Fixes #8.

Caveats:

  1. The catalyst apps don't include icns file, so the icns2png is a NOOP and copies the file from the app's bundle directory to the local temp directory. I chose to leave it as is to add minimal changes to the existing workflow you may have.
  2. The AppIcon file is square, as compared to the icns files with standard apple rounded corners. If you are using a third-party solution to rounding corners on the front end, this won't matter. Otherwise, it would require additional processing to convert the square app icon to a nicer one with rounded corners.

@jeremysarchet
Copy link
Contributor

Exciting! Tried this locally with an iOS app in my dock and the CLI responded gracefully with " icon not found."

@jeremysarchet
Copy link
Contributor

I'm out for the rest of the day, but I'll check in on this PR again tomorrow. Happy to work to get a good solution going together for the icon workflow for Catalyst apps to address the caveats in your PR description.

@raxityo raxityo marked this pull request as ready for review February 1, 2023 18:42
@raxityo
Copy link
Contributor Author

raxityo commented Feb 1, 2023

Hey @jeremysarchet,

Just wanted to share something I found. The caveat # 2 of converting the square to apple's "squircle" icon can be solved in 2 ways that I could find:

  1. Apply the mask on the server side after the image uploads. That way, users don't have to install any image library to mask the image.
  2. Keep the icons square and apply the mask in the front end, like how Apple does it on the AppStore website. This article will be helpful: https://blog.jim-nielsen.com/2017/creating-ios-icon-masks-in-the-browser/. This approach was very easy to prototype, so I tried it out and it turned out nice. :)

Current:

Screenshot 2023-02-01 at 4 58 40 PM

With the Mask on the front end:

Screenshot 2023-02-01 at 4 58 23 PM

@jeremysarchet
Copy link
Contributor

Hey @raxityo. Ooh, very nice, thanks for the research and suggestions. I do like option number 2 quite a bit. Funnily enough, I was referencing that very article about two years ago at my previous job when we wanted to make our web app use all squircles instead of roundrects. It's a great article.

I'm out of time for this week, but your screenshots are appealing. I'll help to make this happen next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Support Catalyst apps
2 participants