DRAFT: completion/sqlmap: simplify code flow (whitespace)

[gaelicWizard]

Description

Convert from indented if-block to return then unindented code. This should have basically one line change at the top, one line removed at the bottom, and then all whitespace. And apply shfmt.

Motivation and Context

Just cleaning up.

NOTE: shellcheck is very unhappy with this file, so I haven't done any fixes related to that.

How Has This Been Tested?

Types of changes

• Bug fix (non-breaking change which fixes an issue)

Checklist:

• My code follows the code style of this project.
• If my change requires a change to the documentation, I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
• I have added tests to cover my changes, and all the new and existing tests pass.

[davidpfarrell]

Another @tbhaxor file - Let them have a chance to review ...

Q: Shouldn't this PR be adding this to clean_files.txt ?

[edit] I see now you state that you didn't run this through shell-check, so thats likely why no clean_files.txt addition ...

[NoahGorny]

I think that only fixing the whitespaces without addressing the shellcheck issues is not important enough to merge IMO.
Every file that we fix without adding it to clean_files.txt might be cluttered again in the future by a mistake

[gaelicWizard]

I think that only fixing the whitespaces without addressing the shellcheck issues is not important enough to merge IMO.
Every file that we fix without adding it to clean_files.txt might be cluttered again in the future by a mistake

Don't let perfect be the enemy of the good!

I always do whitespace changes in a separate commit so that if it gets fingered in a git blame there is minimal confusion before moving on to the next blame.

Either way, I do expect to circle back to clean up the completion function. Just haven't gotten to it yet!

[seefood]

Looks good.