Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random indices in search.py #4

Open
YuhuaBillChen opened this issue Jun 30, 2020 · 1 comment
Open

Random indices in search.py #4

YuhuaBillChen opened this issue Jun 30, 2020 · 1 comment

Comments

@YuhuaBillChen
Copy link

Hi @jack-willturner , I came across the code in search.py and noticed that the sample architecture indices are generated from np.random.randint, which will result in duplicated numbers.

It should not be a big issue when the sampling size is relatively small. However, I think it is better to replace it with np.random.choice to avoid evaluating the same network twice.

Thanks,
Bill

@jack-willturner
Copy link
Collaborator

Good spot, thank you! I'll re-run the experiments with np.random.choice instead and update the code/results soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants