Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the folder ui/viewmodel and ELSeedValidator. Replace RegExpValidator (deprecated) with RegularExpressionValidator. #1121

Open
kogawulf opened this issue May 20, 2024 · 1 comment

Comments

@kogawulf
Copy link
Contributor

kogawulf commented May 20, 2024

Refactor ui/viewmodel

Determine which files and classes are considered "helper" files/objects and move them into appropriate subfolders.
This requires feedback from other contributors to decide best layout.

Suggested (or to be considered) files -- along with their .h counterparts of course

Refactor class ELSeedValidator

  • ELSeedValidator inherits from QValidator, and then seems to implement a regular expression validation manually in its validate() method. The validate method contains the allowed regular expression to be checked against.
  • Shouldn't this operate in the same way as every other validate method? That is, the regular expression is defined in the QML file, in this case SeedInput.qml.
  • So, shouldn't ELSeedValidator simply inherit from RegularExpressionValidator so it can call the parent validate() method to check the regular expression, and then do the extra code in its validate() method?

Refactor RegExpValidator references

RegExpValidator is apparently deprecated and it is recommended to use RegularExpressionValidator

@Maxnflaxl
Copy link
Member

@anatolse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants