You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Determine which files and classes are considered "helper" files/objects and move them into appropriate subfolders.
This requires feedback from other contributors to decide best layout.
Suggested (or to be considered) files -- along with their .h counterparts of course
ELSeedValidator inherits from QValidator, and then seems to implement a regular expression validation manually in its validate() method. The validate method contains the allowed regular expression to be checked against.
Shouldn't this operate in the same way as every other validate method? That is, the regular expression is defined in the QML file, in this case SeedInput.qml.
So, shouldn't ELSeedValidator simply inherit from RegularExpressionValidator so it can call the parent validate() method to check the regular expression, and then do the extra code in its validate() method?
Refactor RegExpValidator references
RegExpValidator is apparently deprecated and it is recommended to use RegularExpressionValidator
The text was updated successfully, but these errors were encountered:
Refactor ui/viewmodel
Determine which files and classes are considered "helper" files/objects and move them into appropriate subfolders.
This requires feedback from other contributors to decide best layout.
Suggested (or to be considered) files -- along with their .h counterparts of course
Refactor class ELSeedValidator
QValidator
, and then seems to implement a regular expression validation manually in its validate() method. The validate method contains the allowed regular expression to be checked against.ELSeedValidator
simply inherit fromRegularExpressionValidator
so it can call the parent validate() method to check the regular expression, and then do the extra code in its validate() method?Refactor RegExpValidator references
RegExpValidator
is apparently deprecated and it is recommended to useRegularExpressionValidator
The text was updated successfully, but these errors were encountered: