3807 update trig and hyp functions #3809
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajpotts
approved these changes
Oct 3, 2024
stress-tess
reviewed
Oct 11, 2024
jaketrookman
approved these changes
Oct 11, 2024
…-Us#3853) Co-authored-by: Tess Hayes <[email protected]>
) When running with multidim, multiloc, and runtime checks, I was having the server crash with this error: ``` $CHPL_HOME/modules/internal/ChapelRange.chpl:2772: error: halt reached - With a positive count, the range must have a first index. ``` It ended up being a fairly easy fix once I ran it down... which took a second because this was a new error to me. This PR fixes Bears-R-Us#3851 Co-authored-by: Tess Hayes <[email protected]>
…Us#3841) * add primitive where-clause evaluation (for instantiateAndRegister) to register_commands.py Signed-off-by: Jeremiah Corrado <[email protected]> * remove uninstantiated overloads from commands annotated with instantiateAndRegister Signed-off-by: Jeremiah Corrado <[email protected]> * remove match statements from register_commands.py Signed-off-by: Jeremiah Corrado <[email protected]> * add error message for 'pad' w/ bigint Signed-off-by: Jeremiah Corrado <[email protected]> * add preliminary support for where-clause evaluation in 'registerCommand' Signed-off-by: Jeremiah Corrado <[email protected]> * fix misinterpretation of explicit type widths (e.g., uint(64)) in where clauses Signed-off-by: Jeremiah Corrado <[email protected]> * fix error message Signed-off-by: Jeremiah Corrado <[email protected]> * fix error message Signed-off-by: Jeremiah Corrado <[email protected]> * refactor 'sum' to not rely on where-clauses for dispatching Signed-off-by: Jeremiah Corrado <[email protected]> * refactor prod, max, and min to take their 'axis' argument as a list Signed-off-by: Jeremiah Corrado <[email protected]> * fix mypy errors and multi-dim build failure Signed-off-by: Jeremiah Corrado <[email protected]> * create list-specific implementations of aryUtil helper procedures used in ReductionMsg. Fix 'axis' argument in 'ak.sum' Signed-off-by: Jeremiah Corrado <[email protected]> * fix return type change to reduction procedures Signed-off-by: Jeremiah Corrado <[email protected]> * fix reducedShape helper for lists Signed-off-by: Jeremiah Corrado <[email protected]> --------- Signed-off-by: Jeremiah Corrado <[email protected]>
This was referenced Oct 23, 2024
|
Superseded by 3863. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3807, updating of trig and hyperbolic functions to new interface.
Only two files are changed:
arkouda/numpy/_numeric.py has two new functions at the top (where_helper and datatype_check), but the primary change is inside _trig_helper, which now calls the trig and hyp functions directly, instead of going through "efunc".
src/EfuncMsg.chpl has new procs for all of these functions, written with the new interface. All of the trig and hyp functions have been removed from the long Select-When clauses that use the old interface.