Skip to content

Commit

Permalink
Drops ie8 support (#79974)
Browse files Browse the repository at this point in the history
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

We currently transpile TGUI down into ie8. This was primarily for Linux
compatibility, which, to my understanding, hasn't worked for quite some
time. As we approach 2024, consider that ie8 is nearly 15 years old and
had its support ended in 2016. I believe sunsetting ie8 is in order.

>I have no objections to remove IE8 support and fully target IE11.

tgstation/tgstation#79943 (comment)

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

- Probably improves performance to some degree, you're only as slow as
your weakest link.
- Reduced maintenance burden
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->

N/A if they can even see this message it doesn't affect them

<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
  • Loading branch information
jlsnow301 authored and itsmeow committed Dec 23, 2024
1 parent c448b57 commit 9c968e7
Show file tree
Hide file tree
Showing 14 changed files with 61 additions and 2,252 deletions.
2 changes: 1 addition & 1 deletion tgui/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"private": true,
"name": "tgui-workspace",
"version": "4.3.0",
"version": "4.4.0",
"packageManager": "[email protected]",
"workspaces": [
"packages/*"
Expand Down
2 changes: 1 addition & 1 deletion tgui/packages/tgui-bench/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"private": true,
"name": "tgui-bench",
"version": "4.3.0",
"version": "4.4.0",
"dependencies": {
"@fastify/static": "^6.12.0",
"common": "workspace:*",
Expand Down
2 changes: 1 addition & 1 deletion tgui/packages/tgui-dev-server/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"private": true,
"name": "tgui-dev-server",
"version": "4.3.0",
"version": "4.4.0",
"type": "module",
"dependencies": {
"axios": "^1.7.9",
Expand Down
330 changes: 0 additions & 330 deletions tgui/packages/tgui-polyfill/00-html5shiv.js

This file was deleted.

Loading

0 comments on commit 9c968e7

Please sign in to comment.