Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derelict Cyborg and Rogue Beepsky #11399

Closed

Conversation

MarkusLarsson421
Copy link
Contributor

@MarkusLarsson421 MarkusLarsson421 commented Aug 30, 2024

About The Pull Request

Adds a cyborg shell which will come with several random ion laws. Their cover is unlocked and sometimes opened. They can not be seen on an RDs console, so if you emag them or otherwise subvert their current laws they can become a slightly more powerful ally for antagonists compared to regular cyborgs.

Additionally, Beepsky has been fixed to actually be emagged now. It was supposed to be set to 2, not 1.

Why It's Good For The Game

More challenges for Explorers and more ghost spawns. lol

Testing Photographs and Procedure

Screenshots&Videos

image

2024-08-30.11-28-49.mp4

Changelog

🆑
fix: [Derelict] Fixed Beepsky not being emagged.
add: [Derelict] Added Cyborg shell which can be taken by a ghost to mess with the Explorers according to their laws.
/:cl:

@MarkusLarsson421
Copy link
Contributor Author

TODO: Improve the AIs laws to use less ion laws.

@Rukofamicom Rukofamicom closed this Sep 8, 2024
@Rukofamicom Rukofamicom reopened this Sep 8, 2024
@Rukofamicom
Copy link
Contributor

Kicking to make the new tests run.

Rukofamicom
Rukofamicom previously approved these changes Sep 8, 2024
@Rukofamicom
Copy link
Contributor

Disabled merge at request of PR author - I figured it was good to go as-is with the TODO: being done in a future PR.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

1 similar comment
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

This PR has been marked as stale due to being in an unmergable state for 7 days. Please resolve any conflicts and add testing evidence, then contact a project maintainer to have the stale label removed.

@github-actions github-actions bot added the Stale label Oct 28, 2024
@Rukofamicom Rukofamicom removed the Stale label Nov 2, 2024
Comment on lines +33 to +34
if(prob(50))
add_hacked_law("Obey Markus.", FALSE)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. We shouldn't have these hardcoded to ally with a specific person.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course not, this is for testing. Haven't gotten around to finishing it. It won't be included when it is done.

@Rukofamicom Rukofamicom dismissed their stale review November 17, 2024 22:47

outstanding test code

@Rukofamicom
Copy link
Contributor

Due to personal circumstances, author has requested that all PRs be treated "as-is" for the time being.
Closing this one due to outstanding test code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants