Make belle_sip_channel_set_public_ip_port() static. #12
+20
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original code tried to map belle_sip_deb(...) (i.e., a variadic
macro) to bctbx_debug(...) (i.e., another variadic macro as the
replacement).
This didn't work for multiple reasons:
- no code used belle_sip_deb(), but actually belle_sip_debug().
- the target function has to be called with either a named variadic
argument (e.g., "nameargs..." -> "nameargs") or, if it's
unnamed/anonymous via the portable __VA_ARGS__ name/macro.
Rename it to belle_sip_debug and make it a non-variadic substitution to
bctbx_debug, since the usage is 1:1 currently.
If it stops being a 1:1 replacement in the future, it's easy to just
make it variadic again such as via:
belle_sip_debug(args...) some_func(NULL, args)
(Still) disabled by default, of course.
Instead, let's just use the proper format specifier. Since belle-sip already requires C99, it should always be available.
No functional change, of course.
…_contact_address_accurate(). It's static, so nothing other than the compilation unit is affected.
Nothing outside of the compilation unit uses it, so it should have been static since its inception. If it does turn out that it needs to be part of the API, we can still make it non-static and export it in a header file.
Ionic
changed the title
belle_sip_channel_set_public_ip_port() static.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need to have
belle_sip_channel_set_public_ip_port()non-static, so make it static instead.It can easily be made API by removing the static keyword again and additionally adding it to the proper header file if needed later on.
Includes #11, so don't review/merge before the other. I'll rebase this PR as soon as #11 is merged.