Changes to bedrock player support

Author: BenCodez

VotingPlugin/Resources/Config.yml

@@ -530,13 +530,11 @@ UseVoteStreaks: true
 # If false, storing best totals will be disabled
 UseHighestTotals: true
 
-# Enable Geyser prefix support
-# May take time before geyser players can vote properly
-# If players vote with prefix, then this is probably not needed and
-# may work better disabled
-# Geyser support is currently hit or miss
-GeyserPrefixSupport: false
-GeyserPrefix: '*'
+# Geyser/Bedrock player support
+# Set prefix used for voting
+# Players should vote with prefix
+# https://github.com/BenCodez/VotingPlugin/wiki/Bedrock-Player-Support
+BedrockPlayerPrefix: '.'
 
 # Whether or not to create daily backups. (Only the most recent ones get kept)
 CreateBackups: true

VotingPlugin/Resources/bungeeconfig.yml

@@ -106,11 +106,9 @@ BungeeManageTotals: true
 # Set DisableBroadcast to true on spigot servers (BungeeSettings.yml) as well
 Broadcast: true
 
-# Geyser settings
-# This may or may not work
-# Does not work on velocity currently
-GeyserSupport: false
-GeyserPrefix: '.'
+# Geyser/bedrock player settings
+# https://github.com/BenCodez/VotingPlugin/wiki/Bedrock-Player-Support
+BedrockPlayerPrefix: '.'
 
 # Time votes will be cached on proxy
 # -1 means no time limit

VotingPlugin/src/com/bencodez/votingplugin/VotingPluginMetrics.java

@@ -324,11 +324,11 @@ public String call() throws Exception {
 			}
 		}));
 
-		metrics.addCustomChart(new BStatsMetrics.SimplePie("geyserprefixsupport", new Callable<String>() {
+		metrics.addCustomChart(new BStatsMetrics.SimplePie("bedrockplayerprefix", new Callable<String>() {
 
 			@Override
 			public String call() throws Exception {
-				return "" + plugin.getOptions().isGeyserPrefixSupport();
+				return "" + plugin.getOptions().getBedrockPlayerPrefix();
 			}
 		}));
 

VotingPlugin/src/com/bencodez/votingplugin/bungee/Config.java

@@ -37,12 +37,8 @@ public boolean getBroadcast() {
 		return getData().getBoolean("Broadcast", false);
 	}
 
-	public boolean getGeyserSupport() {
-		return getData().getBoolean("GeyserSupport", false);
-	}
-
-	public String getGeyserPrefix() {
-		return getData().getString("GeyserPrefix", ".");
+	public String getBedrockPlayerPrefix() {
+		return getData().getString("BedrockPlayerPrefix", ".");
 	}
 
 	public boolean getOnlineMode() {

VotingPlugin/src/com/bencodez/votingplugin/bungee/VotingPluginBungee.java

@@ -1211,15 +1211,10 @@ public synchronized void vote(String player, String service, boolean realVote, b
 			}
 
 			if (uuid.isEmpty()) {
-				if (config.getGeyserSupport()) {
-					if (!player.startsWith(config.getGeyserPrefix())) {
-						uuid = getUUID(config.getGeyserPrefix() + player);
-						player = config.getGeyserPrefix() + player;
-					}
+				if (player.startsWith(config.getBedrockPlayerPrefix())) {
+					getLogger().info("Ignoring vote since unable to get UUID of bedrock player");
+					return;
 				}
-			}
-
-			if (uuid.isEmpty()) {
 				if (config.getAllowUnJoined()) {
 					debug("Fetching UUID online, since allowunjoined is enabled");
 					UUID u = null;

VotingPlugin/src/com/bencodez/votingplugin/bungee/velocity/Config.java

@@ -141,16 +141,12 @@ public boolean getMultiProxyOneGlobalReward() {
 		return getBoolean(getNode("MultiProxyOneGlobalReward"), false);
 	}
 
-	public boolean getGeyserSupport() {
-		return getBoolean(getNode("GeyserSupport"), false);
-	}
-
 	public boolean getPrimaryServer() {
 		return getBoolean(getNode("PrimaryServer"), false);
 	}
 
-	public String getGeyserPrefix() {
-		return getString(getNode("GeyserPrefix"), "*");
+	public String getBedrockPlayerPrefix() {
+		return getString(getNode("BedrockPlayerPrefix"), ".");
 	}
 
 	public ConfigurationNode getMultiProxyServers(String s) {

VotingPlugin/src/com/bencodez/votingplugin/bungee/velocity/VotingPluginVelocity.java

@@ -1247,17 +1247,12 @@ public synchronized void vote(String player, String service, boolean realVote, b
 				uuid = getUUID(player);
 			}
 
-			if (uuid.isEmpty()) {
-				if (config.getGeyserSupport()) {
-					if (!player.startsWith(config.getGeyserPrefix())) {
-						uuid = getUUID(config.getGeyserPrefix() + player);
-						player = config.getGeyserPrefix() + player;
-					}
-				}
-			}
-
 			if (uuid.isEmpty()) {
 				if (config.getAllowUnJoined()) {
+					if (player.startsWith(config.getBedrockPlayerPrefix())) {
+						logger.info("Ignoring vote since unable to get UUID of bedrock player");
+						return;
+					}
 					debug("Fetching UUID online, since allowunjoined is enabled");
 					UUID u = null;
 					try {
@@ -1303,7 +1298,7 @@ public synchronized void vote(String player, String service, boolean realVote, b
 					int dailyTotal = getValue(data, "DailyTotal", 1);
 					int points = getValue(data, "Points", getConfig().getPointsOnVote());
 					int milestoneCount = getValue(data, "MilestoneCount", 1);
-					
+
 					int maxVotes = getConfig().getMaxAmountOfVotesPerDay();
 					if (maxVotes > 0) {
 						LocalDateTime cTime = getBungeeTimeChecker().getTime();