Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voteparty rewards are saved, when triggered for offline participants #1398

Open
1 task
RHX0R3 opened this issue Nov 24, 2024 · 1 comment
Open
1 task

Voteparty rewards are saved, when triggered for offline participants #1398

RHX0R3 opened this issue Nov 24, 2024 · 1 comment
Labels
Possible Feature Possible future feature

Comments

@RHX0R3
Copy link

RHX0R3 commented Nov 24, 2024

Is your feature request related to a problem? Please describe.

It is quite frustrating, when players vote daily, without logging in, triggering the vote party and then don't receive the current item in the SpecialRewards.yml file.

The server I am running, has multiple items, that shuffle weekly.

For example:

  • Week 1: Diamond Shovel
  • Week 2: Diamond Pickaxe
  • Week 3: [...]

If a player gets recognized for the vote party on week 1; then the item changes inside the config to week 2's item; then the player logs in; but receives the wrong item from a week, he did not take part in the vote party.

Describe the solution you'd like

  • A expanded "on hold" or "to be fulfilled" functionality, that saves the exact rewards a player would get from the vote party, in that moment it was triggered.
    Then save it into the database.
    When it copies the vote party rewards of that moment, a MySQL table could look something like this:
    table_example
    So, when the player logs in, he gets all voteparty rewards with the different weekly items the voted for.

Describe alternatives you've considered

Unfortunately there are no alternatives to achieve this. The player HAS to log in atleast once, to get the special reward from the vote party. Otherwise, when the SpecialRewards.yml file changes and the plugin gets reloaded, the reward is not the correct one.

Additional context

none

Best regards,
X0R3

@RHX0R3 RHX0R3 added the Possible Feature Possible future feature label Nov 24, 2024
@RHX0R3 RHX0R3 changed the title Voteparty item is saved, when triggered for offline participants Voteparty rewards are saved, when triggered for offline participants Nov 24, 2024
@BenCodez
Copy link
Owner

You could trigger a reward file for vote parties and switch the reward file (with a different name). As it's the actual reward name/location that determines the reward.

It wouldn't really work to save an entire reward to mysql to ensure the exact reward gets sent, as it would degrade performance and take up a lot of space

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Possible Feature Possible future feature
Projects
None yet
Development

No branches or pull requests

2 participants