Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Kick when teleporting to islands with colored names - Illegal characters in chat #2616

Closed
Zarkness opened this issue Feb 9, 2025 · 1 comment · Fixed by #2618
Closed
Assignees
Labels
Status: Done This issue has been completed or answered. This pull request has been merged.

Comments

@Zarkness
Copy link

Zarkness commented Feb 9, 2025

Expected behavior

Players should be able to teleport to islands with colored names without getting kicked.
The island name should be properly processed, ensuring it does not trigger the Illegal characters in chat kick.
When using tab completion, the island name should appear correctly formatted with color codes, rather than displaying the § character.

Observed/Actual behavior

Observed Behavior:
When teleporting to an island with a colored name, the player gets kicked with the message: Illegal characters in chat. Additionally, when using tab completion to autocomplete the island name, it appears with the § character instead of color codes.

Actual Behavior:
Instead of teleporting normally, the server detects the island name as containing illegal characters and disconnects the player. The § character being shown in tab completion suggests that the name formatting might not be properly handled.

Steps/models to reproduce

Steps to reproduce the problem:

1- Have enabled to be able to have more than 1 island.

2- Create 2 islands or more if you want.

3- In one of the islands change the name to for example &b&lTestName.

4- Try to go to the island with the name &b&lTestName.

As you can see in the video, if I put the name with hexadecimal code it works without problem and it does not kick me, but as soon as I add some legacy format, it is when it gives the problem, if the name is &b&lTest or &#72d379&oTest it already gives the kick.

javaw_4S52VUbrp5.mp4

BentoBox version

Running PAPER 1.21.4.
(1.21.4-136-e0711af (MC: 1.21.4))
BentoBox version: 3.2.4-SNAPSHOT-b2826
Database: JSON
Loaded Game Worlds:
bskyblock_world (BSkyBlock): Overworld, Nether, The End
Loaded Addons:
Biomes 2.2.0 (ENABLED)
Border 4.4.3-SNAPSHOT-b233 (ENABLED)
BSkyBlock 1.19.1-SNAPSHOT-b790 (ENABLED)
Challenges 1.5.0-SNAPSHOT-b580 (ENABLED)
Chat 1.3.0 (ENABLED)
FarmersDance 1.2.0 (ENABLED)
IslandFly 1.14.1 (ENABLED)
Level 2.17.1 (ENABLED)
Likes 2.5.0 (ENABLED)
Limits 1.26.0 (ENABLED)
MagicCobblestoneGenerator 2.7.0-SNAPSHOT-b299 (ENABLED)
TwerkingForTrees 1.5.2 (ENABLED)

Plugin list

Image

Image

Other

No response

@Zarkness Zarkness marked this as a duplicate of #2615 Feb 9, 2025
@tastybento tastybento added the Status: Under investigation Investigating the interest and the feasability of the issue. label Feb 13, 2025
@tastybento tastybento self-assigned this Feb 16, 2025
@tastybento tastybento added Status: In progress Working on the issue. and removed Status: Under investigation Investigating the interest and the feasability of the issue. labels Feb 16, 2025
tastybento added a commit that referenced this issue Feb 16, 2025
There is one issue with AdminMaxHomeCommandTest that I had to ignore.
The mocking is not working.
@tastybento tastybento linked a pull request Feb 16, 2025 that will close this issue
tastybento added a commit that referenced this issue Feb 16, 2025
@tastybento tastybento added Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: In progress Working on the issue. labels Feb 16, 2025
@tastybento
Copy link
Member

Thanks for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Done This issue has been completed or answered. This pull request has been merged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants