Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More freedom with name/description #34

Open
CodfishBender opened this issue Jan 5, 2021 · 4 comments
Open

More freedom with name/description #34

CodfishBender opened this issue Jan 5, 2021 · 4 comments
Labels
Type: Enhancement Improvement or modification which is usually a new feature.

Comments

@CodfishBender
Copy link

CodfishBender commented Jan 5, 2021

Hi there,

I propose a few of edits which will vastly improve this plugins visual capabilities.

Firstly, please allow the ability to make [block] lower case. E.g. "Chicken Limit" instead of "CHICKEN Limit".

Additionally, please allow a single description field for each upgrade type which takes all placeholders.
This way the descriptions can multi-line and customized to anything:

    upgradepanel:
      entity-limit-desc: |
        &a[block] Limit
        &r
        &7Increases the maximum number of
        &6[block] &7on your island.
        &r
        &7Requirements:
        &7Money: &a$[cost]
        &7Island Level: &b[islandlevel]
        &r
        &7Refresh island level with /is level

Behold, a single entry with endless customization.

And finally, please allow the ability to show the current and next limit amount. I.e. The amount of chickens allowed the the current level and also the next level. This allows for a description like:
Upgrade limit: [current] >> [next]

Edit:
It would also be nice if prices were formatted. Currently [cost] will return $1000000, where $1,000,000 would be much easier to read.

@Guillaume-Lebegue Guillaume-Lebegue added the Type: Enhancement Improvement or modification which is usually a new feature. label Jan 5, 2021
@Guillaume-Lebegue
Copy link
Collaborator

Hello, for the description and name, I'm currently working on refactoring how upgrades are made.
I'm doing an admin interface (like the challanges addon) that can customize a lot more things.

As for the placeholders in the description and the price format, that's a good idea.

  • Placeholders description: [current] [next]
  • Cost format

If you have any idea for other placeholders or enhancement, don't hesitate to tell them.

@CodfishBender
Copy link
Author

CodfishBender commented Jan 6, 2021

Thanks for the response, it's really good to hear things are being improved.
I'd like to give one more suggestion in regards to the item description: The ability to create individual descriptions for each tier.

    command-upgrade:
      lambda-upgrade:
        tier2:
          max-level: 2
          island-min-level: "2"
          vault-cost: "[level]*200"
          console: true
          command:
            - "say [player] has upgrade his lambda to level [level]"
            - "say [player] has attained max on BSkyBlock"
          custom-desc: "Description goes here etc.."

In this case the custom-desc would override the locale. If custom-desc is not present or null, it would read from the locale instead.

This allows for completely unique upgrades or tiers alongside the generic upgrades, such as a one-time purchase to summon an end portal, or to activate another feature. Point being, it would be unique from the rest.

@Guillaume-Lebegue
Copy link
Collaborator

It's planned

@Guillaume-Lebegue
Copy link
Collaborator

Sorry for my slow development, but I just made an issue to keep track of what I'm doing.
See #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improvement or modification which is usually a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants