Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Porting to Mu4 #11

Open
Jojo-Schmitz opened this issue Jun 26, 2023 · 25 comments
Open

Porting to Mu4 #11

Jojo-Schmitz opened this issue Jun 26, 2023 · 25 comments

Comments

@Jojo-Schmitz
Copy link

Jojo-Schmitz commented Jun 26, 2023 •
edited
Loading

Here's a port of one of these plugin to Mu4: articulate.zip

Verified to work, see https://musescore.org/en/node/351541#comment-1195813 ff.
It should work for Mu3 too, and the diff might serve as a template to port the others
@BernardGreenberg
Copy link
Owner

This is great. When I test it in MS3, I will post it. Will see about the others...Thank you!

@Jojo-Schmitz
Copy link
Author

Jojo-Schmitz commented Jun 26, 2023 •
edited
Loading

in Mu4 Qt.quit(); crashes Mu on load of the plugin. In Mu3 it is harmfool to, it stops thwe QML engoine and with that all running plugins. iIn Mu4 a plain quit();does the trick, in M3 that doesn't exists, so gives a warning in the plugin editor, but that should be harmless.

IIRC dockable plugins are not (yet) possible in Mu4

@XiaoMigros
Copy link

I remember hearing from Marc Sabatella that even with the 'typical' Mu4 edits the plugins no longer function, or at least, they don't affect how playback sounds

@BernardGreenberg
Copy link
Owner

BernardGreenberg commented Jul 14, 2023 via email

@XiaoMigros
Copy link

'Reload plugins' doesn't do anything at the moment, have you tried restarting the program?

@BernardGreenberg
Copy link
Owner

BernardGreenberg commented Jul 14, 2023 via email

@XiaoMigros
Copy link

I can't immediately see a reason why, but I think it's worth noting that this plugin would not be functional (the play events system isnt present in MuseScore 4 yet)

@BernardGreenberg
Copy link
Owner

BernardGreenberg commented Jul 14, 2023 via email

@Jojo-Schmitz
Copy link
Author

Jojo-Schmitz commented Jul 14, 2023 •
edited
Loading

I'm currently and for the next 2 weeks away for my computer...

@XiaoMigros
Copy link

For me, it's not even showing up at all in the plugin manager tab

@XiaoMigros
Copy link

image
Here are marc's notes on the play events system, for what it's worth (I haven't tested anything myself)

@BernardGreenberg
Copy link
Owner

BernardGreenberg commented Jul 14, 2023 via email

@Jojo-Schmitz
Copy link
Author

Jojo-Schmitz commented Jul 31, 2023 •
edited
Loading

For me, it's not even showing up at all in the plugin manager tab

It does for me:
image
image
image

Dunno whether it does anything to the score, but it certainly does consider it modified, aske for saving the changes, wherever those may be. No errors seen in the logs.

@XiaoMigros
Copy link

Interesting it shows up for you, it still doesn't for me..

Regardless, as Marc said,even though the properties exist and there are no errors encountered when writing them, no changes are made to playback

@BernardGreenberg
Copy link
Owner

BernardGreenberg commented Jul 31, 2023 via email

@Jojo-Schmitz
Copy link
Author

I don't think it actually changed the sound, but it works and apparently changes the score in some form or shape. Haven't investigated in to what the changes are exactly. And no, I've not modified the plugin further, it is the one from the initial post.

@BernardGreenberg
Copy link
Owner

BernardGreenberg commented Jul 31, 2023 via email

@Jojo-Schmitz
Copy link
Author

Anything helpful in the logs?

@BernardGreenberg
Copy link
Owner

BernardGreenberg commented Jul 31, 2023 via email

@Jojo-Schmitz
Copy link
Author

I'm on Windows. The logs should be in ~/Library/Application\ Support/MuseScore/MuseScore4/logs on a Mac

@BernardGreenberg
Copy link
Owner

BernardGreenberg commented Jul 31, 2023 via email

@BernardGreenberg
Copy link
Owner

BernardGreenberg commented Jul 31, 2023 via email

@Jojo-Schmitz
Copy link
Author

Jojo-Schmitz commented Aug 1, 2023 •
edited
Loading

There no log...

BTW: the plugin itself really works, it adds (something like) this to the score (to a note actually:

              <Events>
                <Event>
                  <len>111</len>
                  </Event>
                </Events>

It is just nothing there in Mu4 to interprete that, I guess

@BernardGreenberg
Copy link
Owner

BernardGreenberg commented Aug 1, 2023 via email

@Jojo-Schmitz
Copy link
Author

Probably indeed someone needs to look at it in a Debugger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Jojo-Schmitz @BernardGreenberg @XiaoMigros