Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All promises should be handled #331

Open
Samuel-Therrien-Beslogic opened this issue Dec 13, 2024 · 0 comments · May be fixed by #335
Open

All promises should be handled #331

Samuel-Therrien-Beslogic opened this issue Dec 13, 2024 · 0 comments · May be fixed by #335
Assignees

Comments

@Samuel-Therrien-Beslogic
Copy link
Contributor

At the moment we have lots of promises marked with void , they should be handled at all time (.catch or .then with rejection handler).

All current .catch should be reviewed so that the error is best shown to the user depending on the context.

You can use the useErrorHandling to help get a string from messages. And use openAlertSnackbar to display it. Try to give the user as much info as possible. Strings comming from the backend or JS Exceptions don't need to be translated.

@maximeBAY maximeBAY self-assigned this Dec 16, 2024
@maximeBAY maximeBAY linked a pull request Dec 19, 2024 that will close this issue
5 tasks
@maximeBAY maximeBAY linked a pull request Jan 6, 2025 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants