Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting field type fix #281

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Sorting field type fix #281

merged 1 commit into from
Jun 24, 2024

Conversation

hextraza
Copy link
Contributor

No description provided.

@hextraza hextraza changed the base branch from discvr-24.3 to discvr-23.11 June 20, 2024 18:55
@bbimber
Copy link
Contributor

bbimber commented Jun 21, 2024

hey - I dont know what to make of this test failing on sqlserver but not postgres. this error about backwards-codecs doesnt make a lot of sense as a single-platform issue: https://teamcity.labkey.org/buildConfiguration/LabKey_2311Release_External_Discvr_ExternalModulesTestPostgres/3077089?hideTestsFromDependencies=false&hideProblemsFromDependencies=false&expandBuildDeploymentsSection=false&expandBuildChangesSection=true&expandBuildTestsSection=true.

if this is something related to the DISCVR-seq index now using lucene 3.10, while LK 23.11 uses 3.8, we could just target 24.3 again. however, since this passed on 1/2 agents it doesnt seem like it should be platform specific and it might be a fluke.

I rebased this branch, which should re-trigger the tests to run again

@bbimber bbimber force-pushed the 23.11_fb_sortingTypeFix branch from 0a77c9e to 53d362d Compare June 21, 2024 03:28
@bbimber
Copy link
Contributor

bbimber commented Jun 21, 2024

ah, please disregard my comment on github about platform-specific-ness. i think the failure of postgres (a linux machine) and the tests that can trigger this only run on linux machines

@bbimber bbimber merged commit f4ab831 into discvr-23.11 Jun 24, 2024
3 of 4 checks passed
@bbimber bbimber deleted the 23.11_fb_sortingTypeFix branch June 24, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants